Skip to content

test(editor): implement VS Code interface and source-edit matrices - #193

Draft
Lojhan wants to merge 5 commits into
mainfrom
test/complete-vscode-edit-matrix
Draft

Lojhan wants to merge 5 commits into
mainfrom
test/complete-vscode-edit-matrix

Conversation

@Lojhan

@Lojhan Lojhan commented Sep 6, 2026 •

Copy link
Copy Markdown
Owner

Status: draft, do not merge

The complete interface/edit matrix is implemented. Latest full local run on VS Code 1.134.0: 80/84 VS Code interface cells passed, 4 failed; all 20 edit cases passed; four trust/lifecycle hosts passed. Zed: 84 not-run. Evidence: artifacts/editor-host/results/v-ZnJzo6. Linux CI run 34041160111 reproduces exactly the four coexistence failures (v-L06lg6).

All four failures are builtin-coexistence: with the built-in TypeScript extension enabled, VS Code combines an any hover with the correctly inferred typed-sql row type. Tracked in #196. No failed assertions were removed or downgraded. Provider ownership needs a supported product design, not silently disabling user extensions.

Implementation

21 named interfaces across PostgreSQL, MySQL, SQLite and synthetic. Five edit cases per grammar: local/cross-file rename, document/range formatting and structural quick fixes. Fresh tarball installation, real-server configuration restart with unsaved replay, mixed-grammar multi-root, TSX, ordered parameter tuples, SQL providers and semantic tokens. Exact buffer ownership, SQL preservation and idempotence assertions. Disjoint evidence aggregation rejects mixed versions and duplicate checks.

Merged fixes

PR #197 merged after every applicable required check passed, closing #192, #194 and #195. It fixes folder configuration, isolated host updates/version drift, SQL-hover routing and rapid-open cancellation/immutable snapshots. This draft now includes main. The post-merge runner retains main folder-workspace coverage; focused editor contracts pass. Full matrix evidence above predates this synchronization; new CI is separate.

Closes #191
Related #155, #169 and #196.

Limits

Named interface inventory is not exhaustive SQL syntax or upstream refactor coverage. Actual Zed execution, abrupt real-server crash inference, remote hosts and editor-side stale-edit rejection remain outstanding. The initial single-pass milestone and its failures remain in prior PR history; subsequent fixes and verification were authorized by the merge-and-continue request.

@Lojhan

Lojhan commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

Single local pass completed; no retry. Build/typecheck, quality, packaging and all 15 focused test files passed. Existing 32 grammar cells and four trust/lifecycle hosts passed on VS Code 1.134.0. PostgreSQL extended completed with 12 failed interface checks / 5 failed edit cases due the folder configuration scope blocker (#192). MySQL extended also failed startup, but reported host 1.135.0; its baseline used 1.134.0. The version guard rejected aggregation and stopped the command. The isolated application updater was active. Remaining extended/coexistence hosts were not run.

Final compatible matrix artifact: VS Code 32 passed, 12 failed, 40 not-run; Zed 84 not-run. Edit matrix: 5 failed, 15 not-run. MySQL raw 1.135.0 results remain retained separately, not counted as compatible evidence. No production fixes or post-test code edits were made. Draft PR remains unmerged; the implementation is present but complete host validation is blocked.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(editor): implement complete VS Code interface and source-edit matrices

1 participant