Change widget theme custom CSS fields from TEXT to MEDIUMTEXT to avoid CSS truncation - #2408
Open
mysubcult wants to merge 1 commit into
Open
Change widget theme custom CSS fields from TEXT to MEDIUMTEXT to avoid CSS truncation#2408mysubcult wants to merge 1 commit into
mysubcult wants to merge 1 commit into
Conversation
…ent CSS truncation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modern custom widget themes (with extensive styles, embedded SVG/base64 assets, and responsive CSS rules) can easily exceed the MySQL 64 KB
TEXTlimit (e.g. themes with 70+ KB of CSS). When this occurs, MySQL truncates the CSS content, leading to broken widget styles.Changes
doc/update_db/update_357.sqlmigratinglh_abstract_widget_themeCSS fields (custom_status_css,custom_container_css,custom_widget_css,custom_popup_css) fromTEXTtoMEDIUMTEXT(supporting up to 16 MB).doc/update_db/structure.jsonschema definitions to keep database update checks in sync.