fix: onchain job creator compatibility with full path to repo - #458
Open
arsen3d wants to merge 2 commits into
Open
fix: onchain job creator compatibility with full path to repo#458arsen3d wants to merge 2 commits into
arsen3d wants to merge 2 commits into
Conversation
Contributor
|
@arsen3d how can we test this change? We have a client in lilypad/hardhat/scripts/run-cowsay-onchain.ts Lines 35 to 37 in 564fe64 Is there another way to test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existed demo of on chain cowsay did not provide a way to pass in a repo path. Just repo name.
The update supports passing in a repo path, the same way we do it cli.