build: devnet-contract-deploy - #222
Conversation
|
|
||
| - name: Commit and push | ||
| run: | | ||
| git add . |
There was a problem hiding this comment.
Optional, but might be good to target the directory where we expect changes. Helps to document it a bit better.
There was a problem hiding this comment.
We may need to generate binding, which is not in hardhat directory
There was a problem hiding this comment.
I think @bgins means: git add pkg/web3/bindings
There was a problem hiding this comment.
Have you identified which files are going to be added here?
Can you list them?
There was a problem hiding this comment.
Folders:
* pkg/web3/bindings
* hardhat/deployments
* hardhat/.openzeppelin
There was a problem hiding this comment.
The you have your list for git add
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
bbde6da to
03d98a7
Compare
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
03d98a7 to
ee2521e
Compare
|
@alvin-reyes this PR was addressing the 2nd step in our current 2 step process when deploying changes to the contracts. Let's put a pin on this PR until you've defined and documented our processes, and then we can decide whether we use this PR as base or close this and open a new one for the automations for the CI pipeline. @arsen3d I'm moving this PR back to draft. |
|
Added to engineering board assigned to me |
5 participants
Review Type Requested (choose one):
Summary
Provides a way to migrate contracts on devnet.