Skip to content

build: Update configuration and workflows for Devnet - #152

Merged
bgins merged 6 commits into
mainfrom
bgins/build-devnet-hygiene
Jun 13, 2024
Merged

build: Update configuration and workflows for Devnet#152
bgins merged 6 commits into
mainfrom
bgins/build-devnet-hygiene

Conversation

@bgins

@bgins bgins commented Jun 10, 2024

Copy link
Copy Markdown
Contributor

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

This pull request makes the following changes:

  • Namespace Devnet secrets by prefixing them with DEVNET
  • Remove unused Cloudflare token and Doppler build args
  • Remove Devnet contracts deploy job (we will start with a fresh chain when needed)
  • Rename local_l2 to dev
  • Update run stack command with --network dev
  • Update print-env hardhat script with new Devnet information

Task/Issue reference

Implements: #124
Closes: #136

Details (optional)

We should hold off on merging until we have an Arbitrum Devnet node and Hardhat support for deploying to it. See: #122 and #142

@AquiGorka AquiGorka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 ✨ 🧹🪣 🧼 🫧 thank you @bgins !

@bgins
bgins force-pushed the bgins/build-devnet-hygiene branch 3 times, most recently from 6279b42 to 81355c2 Compare June 13, 2024 17:48
@AquiGorka
AquiGorka force-pushed the bgins/build-devnet-hygiene branch from 0d786a6 to 27b1adb Compare June 13, 2024 18:52
@bgins
bgins force-pushed the bgins/build-devnet-hygiene branch from 27b1adb to dd33b7f Compare June 13, 2024 21:14
@bgins
bgins force-pushed the bgins/build-devnet-hygiene branch from dd33b7f to b1d9cfc Compare June 13, 2024 21:18
@bgins
bgins marked this pull request as ready for review June 13, 2024 21:19
@bgins bgins changed the title build: Rename secrets and remove unused configs build: Update configuration and workflows for Devnet Jun 13, 2024
@bgins
bgins merged commit 6ca4289 into main Jun 13, 2024
@bgins
bgins deleted the bgins/build-devnet-hygiene branch June 13, 2024 21:23
logan-wrld pushed a commit that referenced this pull request Jun 17, 2024
* build: Rename solver, job creator, and contracts secrets

* chore: Remove unused Cloudflare token and Doppler config

* chore: Rename local_l2 to dev

Matches other places where we refer to local development as dev.

* fix: update network on run cmd

* chore: Update print-env network, RPC URL, and chain ID

* build: Remove Devnet contracts deploy job

We have decided to rebuild the chain from scratch on Devnet.

---------

Co-authored-by: Gorka <gorka@aquigorka.com>
@bgins bgins self-assigned this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] nit: remove unneeded build args

2 participants