drop deprecated allow_frozen argument from apply_to_collection call#21781
Open
deependujha wants to merge 1 commit into
Open
drop deprecated allow_frozen argument from apply_to_collection call#21781deependujha wants to merge 1 commit into
allow_frozen argument from apply_to_collection call#21781deependujha wants to merge 1 commit into
Conversation
deependujha
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
June 28, 2026 10:31
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21781 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 270 270
Lines 24005 24005
=======================================
- Hits 20776 20773 -3
- Misses 3229 3232 +3 |
Collaborator
Author
|
failing tests are expected to be fixed after Lightning-AI/utilities#499 is merged, and a new version is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21577
depends on Lightning-AI/utilities#499
allow_frozenis now a deprecated no-op in lightning-utilities (frozen dataclasses are reconstructed automatically), so this removes the now-redundant argument from the_optimizer_to_devicecall to avoid the deprecation warning.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist