fix(Files): remove stale addStyle icons call from TemplateLoader#7641
Merged
vitormattos merged 1 commit intomainfrom May 6, 2026
Merged
fix(Files): remove stale addStyle icons call from TemplateLoader#7641vitormattos merged 1 commit intomainfrom
vitormattos merged 1 commit intomainfrom
Conversation
The `Util::addStyle(Application::APP_ID, 'icons')` call was dead code: - The file `css/icons.css` does not exist in the Vite build output. - Its content (.icon-libresign) is already bundled inside `libresign-tab` via the `tab.ts` entry point importing `./style/icons.scss`. Loading a non-existent CSS file caused a 404 on every Files page with the sidebar open, and any unscoped rule in that file would bleed globally into other Nextcloud apps. Closes #7632 Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/7641/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3c7a8087
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7641/stable32Error: Failed to push branch backport/7641/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead
Util::addStyle(Application::APP_ID, 'icons')call fromTemplateLoader::handle().Root cause
The
css/icons.cssfile does not exist in the Vite build output. Its content (.icon-libresign { background-image: ... }) is already bundled insidelibresign-tab.cssbecausetab.tsimports./style/icons.scss.Having this stale
addStylecall means:list-style: noneregression reported in libresign css affect list-style all over nextcloud #7632.Changes
lib/Files/TemplateLoader.php: Remove the staleUtil::addStyle(Application::APP_ID, 'icons')line.tests/php/Unit/Files/TemplateLoaderTest.php: Add regression testtestHandleDoesNotRegisterIconsStyleSeparately()that assertslibresign/css/iconsis never registered as a standalone stylesheet afterhandle()is called.Ref #7632