Skip to content

feat: cancel signature request notification#6181

Merged
vitormattos merged 16 commits intomainfrom
feat/cancel-signature-request-notification
Dec 14, 2025
Merged

feat: cancel signature request notification#6181
vitormattos merged 16 commits intomainfrom
feat/cancel-signature-request-notification

Conversation

@vitormattos
Copy link
Copy Markdown
Member

No description provided.

This event is dispatched when a signature request is canceled,
allowing listeners to send notifications to the affected user.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…celed

When a signature request with status ABLE_TO_SIGN is deleted,
dispatch the SignRequestCanceledEvent for each identify method.
This allows notification and email listeners to inform users
about the cancellation.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…lation

Creates the Activity components for the cancellation notification:
- SignRequestCanceled settings class
- SignRequestCanceled provider for activity stream

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Implements the notification handler for canceled signature requests.
Sends in-app notifications to users when their signature request
is canceled, respecting user activity settings preferences.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Implements the notification message formatting in Notifier
to display cancellation notifications with proper subject
and message text.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Implements email notification for canceled signature requests.
Sends email to users informing them that their signature
request has been canceled.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Registers the cancellation event in the activity stream,
allowing users to see signature request cancellations
in their activity history.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Registers all three listeners (Notification, Mail, and Activity)
for the SignRequestCanceledEvent in the application bootstrap.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Adds the SignRequestCanceled setting and provider to the
activity section of info.xml, making it available in the
Nextcloud activity system.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Adds Behat tests covering three scenarios:
1. Deleting pending request sends cancellation notification
2. Deleting draft request does not send notification
3. Deletion removes signer from file list

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Changes default values for email and push notifications to false
in LibresignActivitySettings, ensuring all LibreSign activity types
follow the same pattern and respect user opt-in preference.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos added this to the Next Major (33) milestone Dec 13, 2025
@vitormattos vitormattos self-assigned this Dec 13, 2025
@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Dec 13, 2025
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Extracts the SignRequestCanceledEvent dispatching logic from
unassociateToUser into a dedicated dispatchCancellationEventIfNeeded
method for better code organization and single responsibility.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos changed the title Feat: cancel signature request notification feat: cancel signature request notification Dec 13, 2025
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable31

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ceTest

The RequestSignatureService constructor was updated to require 18 parameters
including IEventDispatcher, but the test was only passing 17 parameters.
This commit adds the missing mock dependency to fix all failing tests.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos force-pushed the feat/cancel-signature-request-notification branch from bf8dd6f to 21aee75 Compare December 14, 2025 15:51
@vitormattos vitormattos merged commit e784c39 into main Dec 14, 2025
65 checks passed
@vitormattos vitormattos deleted the feat/cancel-signature-request-notification branch December 14, 2025 16:00
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant