A fix In Message And Reminder Center Button#1614
A fix In Message And Reminder Center Button#1614ahanipeitra1994 wants to merge 5 commits intoLibreHealthIO:masterfrom
Conversation
ahanipeitra1994
changed the title
|
Looks good so far! I just have a few small UI suggestions. The text within the buttons still seems off to me, like it's not fully centered. I would also change the text color to another color like white, so it's easier to see. |
|
Ok I will arange it now on same branch
…On Mon, 8 Jun 2020 at 19:45, Maggie Negm ***@***.***> wrote:
Looks good so far! I just have a few small UI suggestions. The text within
the buttons still seems off to me, like it's not fully centered. I would
also change the text color to another color like white, so it's easier to
see.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1614 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQABPHMZWHR3PWTPMSQEULRVUWTRANCNFSM4NWF7WDA>
.
|
| margin-right: 3px; | ||
| padding-right: 10px; /* sliding doors padding */ | ||
| text-decoration: none; | ||
| text |
There was a problem hiding this comment.
Is this incomplete or supposed to be deleted?
|
@Ngai-E @muarachmann @robbyoconnor can I get one of you to review this? :) |
|
Hmmm looks like I was too hasty when I left my review. Because the text was changed to white and button gif was removed, some buttons now look like this: Can you try to fix this? |
robbyoconnor
left a comment
robbyoconnor
left a comment
There was a problem hiding this comment.
I'm not giving a yay or nay on this, but why didn't you remove the commented out CSS code?
|
|
||
| .css_button_small span { | ||
| background: transparent url( 'theme_assets/bg_button_span_small.gif' ) no-repeat; | ||
| /* background: transparent url( 'theme_assets/bg_button_span_small.gif' ) no-repeat; */ |
There was a problem hiding this comment.
Is there a reason why you didn't just remove this?
There was a problem hiding this comment.
No reason. OK I will remove it now
|
|
||
| .css_button, a[role="button"] { | ||
| background: transparent url( 'theme_assets/bg_button_a.gif' ) no-repeat scroll top right; | ||
| /* background: transparent url( 'theme_assets/bg_button_a.gif' ) no-repeat scroll top right; */ |
|
@ahanipeitra1994 , tried to test this but I still have the default stuffs, also tried switching themes to no avail... maybe a good description will do |
|
Woohoo! Most of the buttons are fixed! Great improvement!
Looks like this issue still exists though. If you take a closer look, you'll notice those reference the "css_button" and "css_button_small" classes. I would start there :) |
| $widgetButtonLabel = xl("Edit"); | ||
| $widgetButtonLink = $GLOBALS['webroot'] . "/interface/patient_file/summary/rx_frameset.php"; | ||
| $widgetButtonClass = "iframe rx_modal"; | ||
| $widgetButtonClass = " iframe rx_modal"; |
There was a problem hiding this comment.
Is there a reason why you added a space here?
There was a problem hiding this comment.
Yes this is because when this variable was used in a function it coincides with another causing the button to be white.
There was a problem hiding this comment.
Is there a reason why you added a space here?
OK testing.
maggienegm
left a comment
maggienegm
left a comment
There was a problem hiding this comment.
I like the gray color of the buttons against the purple background! Looks like there are still some white text buttons though.
| #report_results table { | ||
| border-top: 1px solid black; | ||
| border-bottom: 1px solid black; | ||
| border-bottom: 1px solid black |
5 participants
I fixed the message and reminder button and other buttons which has the same class.