Add explicit save confirmation to garment upload flow - #123
Open
guiu-rocafort wants to merge 2 commits into
Open
Add explicit save confirmation to garment upload flow#123guiu-rocafort wants to merge 2 commits into
guiu-rocafort wants to merge 2 commits into
Conversation
Uploading a garment gave no feedback about whether the save succeeded (Lazztech#15) — creating a garment and attaching its photo both just redirected silently. Add a one-shot success toast after each step (garment created, photo saved), reusing the existing DaisyUI toast/alert pattern from the calendar view, and strip the flag from the URL afterwards so refreshing or sharing the link doesn't replay it. Co-Authored-By: Paperclip <noreply@paperclip.ing>
UX review (LIB-13) found the success toasts added for garment/photo save land at top-20 (80px), directly over the h1 heading for the full 4s they're visible, at both mobile and desktop viewports. Bump to top-36 (144px) so the toast sits over the photo placeholder instead, clear of the heading and the bottom dock nav. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Member
|
This looks like a nice small improvement. I'll take a closer look when I have time but I anticipate merging this. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
Summary
Testing
This change was written with AI assistance.