Skip to content

feat: add committed bytecode foundation#18

Open
RadNi wants to merge 4 commits into
amir/bytecode-stack/02-precommittedfrom
amir/bytecode-stack/03-program-foundation
Open

feat: add committed bytecode foundation#18
RadNi wants to merge 4 commits into
amir/bytecode-stack/02-precommittedfrom
amir/bytecode-stack/03-program-foundation

Conversation

@RadNi
Copy link
Copy Markdown

@RadNi RadNi commented May 21, 2026 •
edited
Loading

Generated stack PR from amir/bytecode-commitment-merged.

Depends on spec PR: a16z#1565

Stack position: 03
Base branch: amir/bytecode-stack/02-precommitted

Owned paths:

jolt-core/src/zkvm/program.rs
jolt-core/src/zkvm/bytecode/chunks.rs
jolt-core/src/zkvm/bytecode/mod.rs
jolt-core/src/zkvm/claim_reductions/bytecode.rs
jolt-core/src/zkvm/claim_reductions/program_image.rs
jolt-core/src/zkvm/claim_reductions/precommitted.rs
jolt-core/src/zkvm/claim_reductions/mod.rs
jolt-core/src/poly/opening_proof.rs
jolt-core/src/poly/rlc_polynomial.rs
jolt-core/src/zkvm/witness.rs
jolt-core/src/zkvm/proof_serialization.rs

This PR is expected to be updated manually when amir/bytecode-commitment-merged is resliced.

@github-actions github-actions Bot added the no-spec PR has no spec file label May 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Warning

This PR has more than 500 changed lines and does not include a spec.

Large features and architectural changes benefit from a spec-driven workflow.
See CONTRIBUTING.md for details on how to create a spec.

If this PR is a bug fix, refactor, or doesn't warrant a spec, feel free to ignore this message.

@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from 5386e59 to 4b2423f Compare May 21, 2026 01:44
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from e4cdbb5 to 744ada7 Compare May 21, 2026 01:44
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from 4b2423f to 3de7f26 Compare May 21, 2026 01:51
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from 744ada7 to d8d5384 Compare May 21, 2026 01:51
@RadNi RadNi changed the title Add committed program foundation [03/05] Add committed program foundation May 21, 2026
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from 3de7f26 to 5217190 Compare May 21, 2026 01:56
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from d8d5384 to 0b06125 Compare May 21, 2026 01:56
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from 5217190 to 9e4300e Compare May 21, 2026 15:37
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from 0b06125 to f33facb Compare May 21, 2026 15:37
@RadNi RadNi changed the title [03/05] Add committed program foundation [03/05] Add committed bytecode foundation May 21, 2026
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from 9e4300e to e2c9276 Compare May 21, 2026 18:02
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from f33facb to 77801f2 Compare May 21, 2026 18:02
@RadNi RadNi marked this pull request as ready for review May 21, 2026 18:10
@RadNi RadNi changed the title [03/05] Add committed bytecode foundation feat: add committed bytecode foundation May 21, 2026
moodlezoup
moodlezoup reviewed May 22, 2026
View reviewed changes
Comment thread jolt-core/src/zkvm/claim_reductions/bytecode.rs Outdated
pub eta_powers: [F; NUM_VAL_STAGES],
/// Eq weights over high bytecode address bits (one per committed chunk).
pub chunk_rbc_weights: Vec<F>,
pub bytecode_T: usize,
Copy link
Copy Markdown

@moodlezoup moodlezoup May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log_chunk_size or something would be more accurate

Comment thread jolt-core/src/zkvm/claim_reductions/bytecode.rs Outdated
Comment on lines +425 to +433
accumulator.append_virtual(
VirtualPolynomial::BytecodeClaimReductionIntermediate,
SumcheckId::BytecodeClaimReductionCyclePhase,
opening_point.clone(),
);
let opening_point_le: OpeningPoint<LITTLE_ENDIAN, F> = opening_point.match_endianness();
params
.precommitted
.set_cycle_var_challenges(opening_point_le.r);
Copy link
Copy Markdown

@moodlezoup moodlezoup May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need set_cycle_var_challenges if we're already appending the point to the accumulator? If we don't need it, we can get avoid wrapping params in RefCell and therefore avoid the unsafe block in get_params

Comment thread jolt-core/src/zkvm/claim_reductions/program_image.rs Outdated
Comment on lines +427 to +429
params
.precommitted
.set_cycle_var_challenges(opening_point_le.r);
Copy link
Copy Markdown

@moodlezoup moodlezoup May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from 77801f2 to d1eb7e0 Compare May 22, 2026 15:57
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from e2c9276 to c3153f9 Compare May 22, 2026 15:57
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch 2 times, most recently from 78c82ba to 9d5b82e Compare May 22, 2026 17:30
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from d340832 to 6c29ef5 Compare May 22, 2026 17:30
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from 9d5b82e to e587e65 Compare May 22, 2026 17:48
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from a5ed82a to a6bfc73 Compare May 22, 2026 19:53
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch 2 times, most recently from 36378dd to 850790c Compare May 23, 2026 06:57
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from 0f357e1 to 5ca9b21 Compare May 25, 2026 18:46
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from 850790c to 268b434 Compare May 25, 2026 18:46
quangvdao and others added 2 commits May 25, 2026 20:36
@quangvdao @RadNi @cursoragent
feat(zkvm): add committed program preprocessing foundation
a6b2529 
Co-authored-by: Amirhossein Khajehpour <khajepour.amirhossein@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@RadNi @cursoragent
feat(zkvm): add committed program claim reductions
09e8936 
Co-authored-by: Cursor <cursoragent@cursor.com>
RadNi and others added 2 commits May 25, 2026 20:36
@RadNi @cursoragent
refactor(zkvm): clarify bytecode sizing names
d77a2c2 
Co-authored-by: Cursor <cursoragent@cursor.com>
@RadNi @cursoragent
fix(zkvm): align committed reduction challenges
bf067dd 
Preserve the intended cycle-phase opening data for bytecode and program-image claim reductions across verifier transitions.

Made-with: Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@RadNi RadNi force-pushed the amir/bytecode-stack/02-precommitted branch from e0ed5d6 to c41f679 Compare May 26, 2026 04:02
@RadNi RadNi force-pushed the amir/bytecode-stack/03-program-foundation branch from 268b434 to bf067dd Compare May 26, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moodlezoup moodlezoup moodlezoup left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-spec PR has no spec file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RadNi @moodlezoup @quangvdao