refactor: split stage 6 sumchecks#16
Open
RadNi wants to merge 14 commits into
Open
Conversation
github-actions
Bot
added
spec
RadNi
force-pushed
the
amir/bytecode-stack/01-stage6-split
branch
2 times, most recently
from
b561ac0 to
e528eda
Compare
RadNi
force-pushed
the
amir/bytecode-stack/01-stage6-split
branch
2 times, most recently
from
be768fc to
4624ea6
Compare
37 tasks
RadNi
changed the title
RadNi
changed the base branch from
amir/bytecode-stack/base-origin-main
to
amir/bytecode-commitment-stack-base
moodlezoup
reviewed
May 22, 2026
Comment on lines
+1285
to
+1291
| // Stage 6a input claims depend on hidden prior-stage outputs in ZK mode, | ||
| // so we prove it with a ZK sumcheck proof. We keep a local blindfold | ||
| // accumulator so this split-internal phase does not add a new global | ||
| // BlindFold stage. | ||
| let mut rng = rand::thread_rng(); | ||
| let mut local_blindfold = | ||
| crate::subprotocols::blindfold::BlindFoldAccumulator::<F, C>::new(); |
There was a problem hiding this comment.
cc @0xAndoroid does this look right to you?
|
Warning This PR has more than 500 changed lines and does not include a spec. Large features and architectural changes benefit from a spec-driven workflow. If this PR is a bug fix, refactor, or doesn't warrant a spec, feel free to ignore this message. |
github-actions
Bot
added
no-spec
RadNi
force-pushed
the
amir/bytecode-stack/01-stage6-split
branch
from
0eddf1c to
3e44c13
Compare
github-actions
Bot
added
spec
Use phase-specific stage6a/stage6b sumcheck params and proof wiring so zk transcript and constraints stay aligned after splitting stage6. This preserves the split design while fixing zk failures without introducing bytecode-commitment features. Made-with: Cursor (cherry picked from commit e9ec21c) Co-authored-by: Amirhossein Khajehpour <khajepour.amirhossein@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep stage6a on the standard batched sumcheck path and derive cycle-phase booleanity params in stage6b so the split matches the reference branch. Made-with: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Treat stage6a as its own BlindFold stage after splitting stage6 so prover and verifier agree on the ZK stage layout. Made-with: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
RadNi
force-pushed
the
amir/bytecode-stack/01-stage6-split
branch
from
3e44c13 to
4175c7a
Compare
RadNi
changed the base branch from
amir/bytecode-commitment-stack-base
to
amir/bytecode-stack/base-origin-main
RadNi
changed the base branch from
amir/bytecode-stack/base-origin-main
to
amir/bytecode-commitment-stack-base
RadNi
force-pushed
the
amir/bytecode-commitment-stack-base
branch
from
9da1de7 to
fdf890d
Compare
Reuse the RA indices computed during the booleanity address phase by passing an opaque cycle input into the cycle phase, keeping prover orchestration unaware of booleanity internals.
github-actions
Bot
added
no-spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated stack PR from
amir/bytecode-commitment-merged.Depends on spec PR: a16z#1565
Stack position:
01Base branch:
amir/bytecode-commitment-stack-baseOwned paths:
This PR is expected to be updated manually when
amir/bytecode-commitment-mergedis resliced.