Skip to content

Remove obsolete notebooks#662

Open
marcpaterno wants to merge 7 commits into
masterfrom
remove-obsolete-notebooks
Open

Remove obsolete notebooks#662
marcpaterno wants to merge 7 commits into
masterfrom
remove-obsolete-notebooks

Conversation

@marcpaterno

@marcpaterno marcpaterno commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR removes tracked example Jupyter notebooks and related notebook-specific
repository handling, updates the development environment to use ipykernel and
ipython instead of the jupyter meta-package, and drops the CI notebook
cleanup action. It also aligns the pinned conda-lock version used by the
lockfile generation script, reusable CI workflow, and contributor
documentation.

The example Cobaya tests now invoke cobaya-run with --no-mpi so the example
runs do not require MPI.

Type of change

  • Refactoring
  • I have run make pre-commit and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

Drop the notebook cleanup CI action, remove notebook checkpoint ignore
rules, and replace the Jupyter dependency with ipykernel and ipython in
the development environment.

Delete the tracked cluster example notebooks so the repository no longer
carries notebook artifacts.
Update the pinned conda-lock version in the lockfile generation script,
reusable CI workflow, and contributor documentation so lockfile
generation and CI use the same tool version.
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (055b907) to head (39872c1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         150      150           
  Lines        8721     8734   +13     
  Branches     1038     1040    +2     
=======================================
+ Hits         8721     8734   +13     
Files with missing lines Coverage Δ
firecrown/fctools/link_checker.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Make the clean-docs target remove all directories generated when
building the documentation, to help ensure that a clean build of the
documentation does not accidentally make use of stale information.
This change exchanges separate ipykernel and ipython dependencies for
the jupyter metapackage in environment.yml, which transitively includes
both packages plus additional interactive computing dependencies. The
conda lock files were regenerated to reflect this change and now include
many new packages for the Jupyter ecosystem including jupyterlab,
jupyter_server, ipywidgets, and their transitive dependencies.

The primary change is in the environment definition; no functional code
was modified.
Detect CI environments and switch broken-link reporting from table
format to line-by-line output that preserves full source and target
paths in logs. Keep table output as the default for local interactive
use and add a CLI toggle to explicitly choose full or table output.

Add tests covering CI default full output and explicit table output in
CI mode.
@marcpaterno
marcpaterno requested a review from vitenti July 24, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants