fix(synccontrols): implement proper lifecycle for XSet deletion#33
Open
fix(synccontrols): implement proper lifecycle for XSet deletion#33
Conversation
修改 BatchDeleteTargetsByLabel 函数,使其遵循与 scale-in 相同的生命周期模式: 1. 触发 TargetOpsLifecycle (opslifecycle.Begin) 2. 等待操作许可 (opslifecycle.AllowOps) 3. 直接删除目标 (DeleteTarget) 4. 清理 PVC 资源 之前该函数仅添加 to-delete 标签,需要额外的控制器来处理删除。 现在直接处理删除,与 scale-in 保持一致。
…etsByLabel PVC cleanup is already handled by ensureReclaimPvcs in xset_controller.go before BatchDeleteTargetsByLabel is called. The previous PVC deletion code was broken because DeleteTargetPvcs requires the pvcs parameter which was nil. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改 BatchDeleteTargetsByLabel 函数,使其遵循与 scale-in 相同的生命周期模式:
之前该函数仅添加 to-delete 标签,需要额外的控制器来处理删除。
现在直接处理删除,与 scale-in 保持一致。
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.