Skip to content

fix: return bool instead of tuple in HTTPRoute _ready #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
averevki merged 1 commit into from
May 15, 2026
Merged

fix: return bool instead of tuple in HTTPRoute _ready #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testsuite/gateway/gateway_api/route.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def _ready(obj):
condition_set.controllerName in expected_controllers
or "gateway-controller" in condition_set.controllerName # fallback
):
return (all(x.status == "True" for x in condition_set.conditions),)
return all(x.status == "True" for x in condition_set.conditions)
return False

success = self.wait_until(_ready, timelimit=10)
Expand Down
Loading