Skip to content

feat: add --pprof-bind-address flag for runtime profiling#612

Draft
mikenairn wants to merge 1 commit into
mainfrom
add-pprof-bind-address
Draft

feat: add --pprof-bind-address flag for runtime profiling#612
mikenairn wants to merge 1 commit into
mainfrom
add-pprof-bind-address

Conversation

@mikenairn
Copy link
Copy Markdown
Member

@mikenairn mikenairn commented May 14, 2026

Summary

Adds runtime profiling support via Go's built-in pprof using controller-runtime's PprofBindAddress option. Enabled by default on :8082.

Motivation

pprof is the standard mechanism for diagnosing performance issues in Go applications. The Kubernetes kube-apiserver enables profiling via --profiling (default: true), exposing the same /debug/pprof/ endpoints. OpenShift provides built-in tooling for collecting pprof data from cluster components.

The dns-operator already has this flag enabled by default on :8082. This PR brings Authorino in line.

Changes

  • Added pprofAddr field to commonServerOptions struct
  • Added --pprof-bind-address flag (default :8082) via cobra PersistentFlags
  • Added PprofBindAddress to both the auth server and webhook server ctrl.Options
  • Added ## Profiling section to README.md

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6e6c61d5-d1eb-46dd-b76a-8b53bf5520c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-pprof-bind-address

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Adds pprof endpoint support using controller-runtime's
built-in PprofBindAddress. Enabled by default on :8082.

Signed-off-by: Michael Nairn <mnairn@redhat.com>
@mikenairn mikenairn force-pushed the add-pprof-bind-address branch from 341ff75 to 612fe0d Compare May 25, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants