feat: add --pprof-bind-address flag for runtime profiling#612
Draft
mikenairn wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
Adds pprof endpoint support using controller-runtime's built-in PprofBindAddress. Enabled by default on :8082. Signed-off-by: Michael Nairn <mnairn@redhat.com>
341ff75 to
612fe0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds runtime profiling support via Go's built-in pprof using controller-runtime's
PprofBindAddressoption. Enabled by default on:8082.Motivation
pprof is the standard mechanism for diagnosing performance issues in Go applications. The Kubernetes kube-apiserver enables profiling via
--profiling(default:true), exposing the same/debug/pprof/endpoints. OpenShift provides built-in tooling for collecting pprof data from cluster components.The dns-operator already has this flag enabled by default on
:8082. This PR brings Authorino in line.Changes
pprofAddrfield tocommonServerOptionsstruct--pprof-bind-addressflag (default:8082) via cobra PersistentFlagsPprofBindAddressto both the auth server and webhook serverctrl.Options## Profilingsection to README.md