Keep manual hyphens after line breaks#2840
Closed
Sanjays2402 wants to merge 1 commit into
Closed
Conversation
When Pango split a fitting line at a soft hyphen, the no-next-word fast path returned before WeasyPrint appended hyphenate-character. Let soft-hyphen line endings reach manual hyphenation and cover the reported 11pt layout with a regression test. Fixes Kozea#2614
Member
|
Hi.
The problem is not the exact 11pt size, that was just a random value in the bug report to show the problem. The test doesn’t even set a font family, the fix is only there to make the test pass, I’m pretty sure you don’t really know what you’re doing. 
LOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 11pt, Pango can return a fitting line ending in the invisible soft hyphen. The no-next-word fast path returned before manual hyphenation appended
hyphenate-character; letting that case continue fixes the reported rendering.The regression test reproduces the missing visible hyphen without the source change and passes with it.
tests/test_text.py: 153 passed, 1 xfailed.Fixes #2614.