Resolve conflicts of var-properties with different types#338
Conversation
Schahen
left a comment
Schahen
left a comment
There was a problem hiding this comment.
Let's discuss and move forward. I'm totally pro merging this and my goal for today is to move forward with all PR accumulated throughout previous wee as fast as possible.
(Then they are actually not conflicting in this case)
Schahen
left a comment
Schahen
left a comment
There was a problem hiding this comment.
Still requesting changes - it's getting better but still some work to do before ending up in master )
|
|
||
| val propertiesInImmediateParents = properties.filter { first -> | ||
| properties.none { second -> | ||
| inheritanceContext.isDescendant(second.ownerModel, first.ownerModel) |
There was a problem hiding this comment.
We should collect actual parent instead collecting all parents and then filtering out this way ) (check out ModelContext::getParents)
There was a problem hiding this comment.
What about this case?
interface A {
x: number
}
interface B : A {
}
interface C : B {
x: number
}
I still want to get x from A in this case, that's why I can't use something like ModelContext::getParents. So I believe I'm right in this place -- the name can be misleading though, can you suggest what change it to?
2 participants
No description provided.