Skip to content

Apply runner filters to requests/iterations as well as tests [INS-3348] - #10353

Draft
godfrzero wants to merge 3 commits into
developfrom
feat/INS-3348-runner-filters
Draft

Apply runner filters to requests/iterations as well as tests [INS-3348]#10353
godfrzero wants to merge 3 commits into
developfrom
feat/INS-3348-runner-filters

Conversation

@godfrzero

Copy link
Copy Markdown
Contributor

Using the Passed/Failed/Skipped filters in the collection runner results currently only filter through tests, leaving requests/iterations in place even if there are no matching children.

image

This can lead to a degraded experience in scenarios where there may be a large number of requests/tests/iterations with very few failures/successes. Engaging a filter in such a case will still lead to a significant amount of screen real estate being dedicated to "empty" requests/iterations, thereby still necessitating that the user manually scroll to find the test that's failing/passing/skipped. This PR updates the filter logic to:

  • Hide a request altogether if there are no tests matching the filter criteria.
  • Hide an iteration if there are no tests matching the filter criteria.
Before After
image image

Since it's now possible for the entire pane to be empty if nothing matches a filter, this PR also adds a very basic empty state:

image

Changes were tested manually by running collections of various sizes for 1-10 iterations, and automated tests have also been added to verifythe internal business logic. Tests to actually run through the GUI have not been added since they've proven to be a source of flakiness, and the business logic-only tests should be good enough IMO.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

✅ Circular References Report

Generated at: 2026-08-07T22:16:05.755Z
Status: ✅ NO CHANGE

Summary

Metric Base (develop) PR Change
Total Circular References 9 9 0 (0.00%)
Click to view all circular references in PR (9)
insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia/src/main/prompt-bridge.ts -> insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/network/network.ts -> insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx
Click to view all circular references in base branch (9)
insomnia-inso/src/db/models/types.ts -> insomnia-inso/src/db/types.ts
insomnia/src/main/prompt-bridge.ts -> insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/main/window-utils.ts -> insomnia/src/main/plugin-window.ts
insomnia/src/network/network.ts -> insomnia-scripting-environment/src/objects/index.ts -> insomnia-scripting-environment/src/objects/collection.ts -> insomnia-scripting-environment/src/objects/response.ts
insomnia/src/network/network.ts -> insomnia/src/common/render.ts
insomnia/src/ui/components/settings/import-export.tsx -> insomnia/src/ui/components/modals/export-requests-modal.tsx
insomnia/src/ui/components/tabs/tab-list.tsx -> insomnia/src/ui/components/tabs/tab.tsx
insomnia/src/ui/components/templating/tag-editor-arg-sub-form.tsx -> insomnia/src/ui/components/templating/external-vault/external-vault-form.tsx
insomnia/src/ui/components/viewers/response-viewer.tsx -> insomnia/src/ui/components/viewers/response-multipart-viewer.tsx

Analysis

No Change: This PR does not introduce or remove any circular references.


This report was generated automatically by comparing against the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant