feat(arch): add create/update/delete Environment use-cases to the Insomnia facade - #10342
Draft
gatzjames wants to merge 1 commit into
Draft
Conversation
…omnia facade Rounds out the Environment aggregate's core CRUD on the application-layer facade, mirroring the Workspace pattern from the prior PR. EnvironmentModule gains create()/updateById()/deleteById(), wired to their real route call sites: environment.create.tsx, environment.update.tsx (a generic patch, matching the route's existing shape), and environment.delete.tsx. The "cannot delete the base environment" business rule moves into deleteEnvironment() itself (parentId === workspaceId), replacing the route's previous two-lookup invariant with a single check inside the use-case. EnvironmentRepository gains a create() port method (backed by services.environment.create in the NeDB adapter), with a matching contract-test case. environment.duplicate.tsx and both set-active routes are intentionally left untouched: duplicate() needs sibling-sort-key querying the current repository port doesn't expose, and set-active/set-active-global mutate WorkspaceMeta, not Environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.