chore: Phase 1b - move configure-v3-client/insomnia-fetch behind insomnia-api - #10329
Draft
gatzjames wants to merge 1 commit into
Draft
chore: Phase 1b - move configure-v3-client/insomnia-fetch behind insomnia-api#10329gatzjames wants to merge 1 commit into
gatzjames wants to merge 1 commit into
Conversation
…mnia-api Relocates configureV3ClientDefaults, insomniaFetch/proxyAwareFetch, and the four small constants they depend on (getApiBaseURL, getClientString, INSOMNIA_FETCH_TIME_OUT, PLAYWRIGHT_TEST) from packages/insomnia/src into insomnia-api, which both desktop and the CLI already depend on. Desktop's own common/constants.ts, common/insomnia-fetch.ts and common/configure-v3-client.ts become thin re-export shims (same pattern already used for generateId in misc.ts), so every existing desktop import path keeps working unchanged. insomnia-inso's cli.ts now imports configureV3ClientDefaults/insomniaFetch from insomnia-api directly instead of reaching into packages/insomnia/src. getClientString's version string now reads insomnia-api's own package.json instead of desktop's - safe because every workspace package in this monorepo is released with the same synchronized version number, so the resulting string is identical today and stays identical going forward. send-request.node.ts's relocation is deliberately deferred (curl/scripting/ vault coupling makes it a separate, higher-risk piece of work) - the CLI still reaches into packages/insomnia/src/network/send-request.node for now. Verified via insomnia-api/insomnia-inso/insomnia unit tests (139 test files, 2175 tests passing in packages/insomnia alone) and the full inso dev-bundle e2e suite, including tests that exercise the real network path (insomnia.sendRequest, run collection HTTP requests) - all pass unchanged.
✅ Circular References ReportGenerated at: 2026-08-04T19:27:53.149Z Summary
Click to view all circular references in PR (8)Click to view all circular references in base branch (8)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
ZxBing0066
reviewed
Aug 5, 2026
| @@ -0,0 +1,96 @@ | |||
| import { generateRequestId, getApiBaseURL, getClientString, INSOMNIA_FETCH_TIME_OUT, PLAYWRIGHT_TEST } from './client-defaults'; | |||
Member
There was a problem hiding this comment.
I don't think we should move insomnia-fetch into insomnia-api since fetch is runtime-related and insomnia-api is runtime-agnostic. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.