chore: Phase 1a - replace inso's duplicate NeDB reader/models with insomnia-data - #10328
Draft
gatzjames wants to merge 1 commit into
Draft
chore: Phase 1a - replace inso's duplicate NeDB reader/models with insomnia-data#10328gatzjames wants to merge 1 commit into
gatzjames wants to merge 1 commit into
Conversation
…somnia-data Deletes insomnia-inso's hand-duplicated model types (db/models/types.ts) and repoints db/types.ts and every db/models/*.ts file at insomnia-data's real model types instead. ne-db-adapter.ts still reads .db files directly (read-only, never touches the real app-data directory in non-memory mode to avoid triggering repairDatabase()), but now hydrates the docs into an in-memory insomnia-data IDatabase so they go through the same model init/migration logic the desktop app and CLI network path already use, instead of being returned as raw, un-migrated JS objects. Also fixes two WorkspaceMeta literals in cli.ts's --globals handling and insomnia-adapter.ts's raw-type mapping to satisfy insomnia-data's real (stricter) model types. Verified via unit tests, and the full inso dev-bundle e2e suite (run test/run collection/lint spec/export spec against real nedb fixtures, plus report-generation snapshot tests) - all pass unchanged.
✨ Circular References ReportGenerated at: 2026-08-04T19:29:42.899Z Summary
✨ Circular References Removed (1)Click to expand/collapseClick to view all circular references in PR (8)Click to view all circular references in base branch (9)Analysis✨ Great Job! This PR removes 1 circular reference. Keep up the good work! This report was generated automatically by comparing against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.