Skip to content

Minor corrections for accuracy in error messages and comments in AuthUtils #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsadok wants to merge 1 commit into from
Closed

Minor corrections for accuracy in error messages and comments in AuthUtils #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Koha/AuthUtils.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ sub generate_salt {
my $source;

if ( $length < 1 ) {
die "non-positive strength of '$strength' passed to Koha::AuthUtils::generate_salt\n";
die "non-positive length of '$length' passed to Koha::AuthUtils::generate_salt\n";
}

if ( $strength eq "strong" ) {
Expand All @@ -130,7 +130,7 @@ sub generate_salt {
# $string is the concatenation of all the bytes read so far
my ( $bytes, $string ) = ( "", "" );

# keep reading until we have $length bytes in $strength
# keep reading until we have $length bytes in $string
while ( length($string) < $length ) {

# return the number of bytes read, 0 (EOF), or -1 (ERROR)
Expand All @@ -154,7 +154,7 @@ sub generate_salt {
my ( $is_valid, $error ) = is_password_valid( $password, $category );

return $is_valid == 1 if the password match category's minimum password length and strength if provided, or general minPasswordLength and RequireStrongPassword conditions
otherwise return $is_valid == 0 and $error will contain the error ('too_short' or 'too_weak')
otherwise return $is_valid == 0 and $error will contain the error ('too_short', 'too_weak', or 'has_whitespaces')

=cut

Expand Down
Loading