[WIP] gpuav: PoisonPass#12038
Open
jeffbolznv wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Conversation
Model propagation of poison values in gpuav by tracking shadow values for anything that could potentially be poison. When a poison value could be used in a way that leads to undefined behavior, insert a check for poison and report an error (and skip the undefined behavior). The "potentially poison" values are seeded based on uninitialized variables. This detects a real problem we see in practice where applications rely on specific compiler behavior or implicit zero-initialization of temporaries, and breaks when the compiler is updated. In the future, this pass could also be seeded with other sources of poison (e.g. shifting by too large of a value). This code was largely AI-generated, with a bunch of review/feedback from me.
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 699167. |
Collaborator
|
CI Vulkan-ValidationLayers build # 23031 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 23031 failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model propagation of poison values in gpuav by tracking shadow values for anything that could potentially be poison. When a poison value could be used in a way that leads to undefined behavior, insert a check for poison and report an error (and skip the undefined behavior).
The "potentially poison" values are seeded based on uninitialized variables. This detects a real problem we see in practice where applications rely on specific compiler behavior or implicit zero-initialization of temporaries, and breaks when the compiler is updated. In the future, this pass could also be seeded with other sources of poison (e.g. shifting by too large of a value).
This code was largely AI-generated, with a bunch of review/feedback from me.
WIP because I still want to do more testing with real apps.