Add shaderDrawParameters to earlier triangle tutorial pages#366
Open
JoelleJS wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Add shaderDrawParameters to earlier triangle tutorial pages#366JoelleJS wants to merge 1 commit intoKhronosGroup:mainfrom
JoelleJS wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following along with the tutorial the Vulkan 1.1 feature
shaderDrawParametersis not added to the required features and you run into the validation layers complaining by the end of the Shader modules chapter. The code for that chapter does silently add it, but it is never mentioned in the tutorial. This commit adds it to the earlier code and documentation.