Add showAngles option to polygon locked figure#3481
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
github-actions
Bot
added
the
schema-change
Contributor
🗄️ Schema Change: Changes Detected
|
Contributor
|
Size Change: +109 B (+0.02%) Total Size: 499 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: Changes Detected
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (126d673) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3481If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3481If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3481 |
Author
|
I'll be following through with the CI failures next week! |
… option to polygon locked figure
SonicScrewdriver
approved these changes
Apr 14, 2026
Contributor
SonicScrewdriver
left a comment
SonicScrewdriver
left a comment
There was a problem hiding this comment.
This honestly looks great to me, thank you so much for getting this feature built!
I'm happy to approve as I only have a couple small change requests regarding piping through the showAngles value in the question builders, and the hard coded angle snapping.
I'll chat with you elsewhere about when to land/deploy this, as we'll need to coordinate with the platform team due to the schema changes — otherwise we could bring down publishing if we attempt to use the new value. ;)
| points: points, | ||
| color: "grayH", | ||
| showVertices: false, | ||
| showAngles: false, |
Contributor
There was a problem hiding this comment.
We should pipe in the options.showAngles value here so that we can use the builder in tests/storybook. :)
| @@ -0,0 +1,157 @@ | |||
| import {render, screen} from "@testing-library/react"; | |||
Contributor
There was a problem hiding this comment.
It seems like we were previously just using the global set of tests in locked-function.test.tsx, but I like the coverage and organization here, so I'm all far it. :)
| endPoints={[pt1, pt2]} | ||
| areEndPointsClockwise={clockwise(points)} | ||
| showAngles={showAngles} | ||
| snapTo="grid" |
Contributor
There was a problem hiding this comment.
I'm noticing that you've hard-coded this to grid!
That's fine if that's all you will ever need for locked figures, but you may want to consider setting up the full angle snapping setting for locked polygons. If you don't need the full angle snapping logic, I'd love a comment here with a brief explanation for the hard coded value for our future selves. :)
| points: points, | ||
| color: "grayH", | ||
| showVertices: false, | ||
| showAngles: false, |
Contributor
There was a problem hiding this comment.
We should pipe in the options.showAngles value here so that we can use the builder in tests/storybook. :) (For both builders)
catandthemachines
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extend the polygon locked figure to include a
showAnglesoption similar to the polygon interactive graph.I'm contributing upstream to Perseus becuase this feature would enable the Visual Output team to lean on Perseus for computing and displaying angles rather than trusting the LLM to do the math. I plan on following up with a change to allow these angle measure labels to be configurable per-vertex.
Feel free to nit-pick style / conventions, and let me know if I'm missing any tests!
Test plan:
pnpm lint && pnpm testonChangePropswhen toggled in locked polygon settings (mirrors existing test cases)packages/perseus/src/widgets/interactive-graphs/graphs/polygon.test.tsx