[ Interactive Graph | Vector Graph ] PR4: Scoring by SonicScrewdriver · Pull Request #3442 · Khan/perseus

SonicScrewdriver · 2026-04-01T00:06:17Z

Summary

This PR was created with the help of AI, albeit with heavy oversight and review.

This is part of a series of PRs implementing the vector graph type for the Interactive Graph widget:

PR1 – type definitions and schema
PR2 – state management
PR3 – rendering & accessibility
▶️ PR4 – scoring (this PR)
PR5 – editor support

Issue: LEMS-3971

Added scoring logic for the vector graph type. The graph is now gradeable.

Changes:

score-interactive-graph.ts — Adds vector scoring branch. Both tail (coords[0]) and tip (coords[1]) must match exactly via approximateDeepEqual. Unlike ray (which uses collinear for the second point), vector scoring is order-sensitive — swapping tail and tip is incorrect.
score-interactive-graph.test.ts — 6 new tests: undefined guess (invalid), missing coords (invalid), correct answer, wrong tail (incorrect), wrong tip (incorrect), swapped tail and tip (incorrect).

Test plan:

pnpm tsc — no new type errors
pnpm test packages/perseus-score/src/widgets/interactive-graph/ — 44 tests pass, including 6 new vector scoring tests
No existing scoring tests regress

github-actions · 2026-04-01T00:07:36Z

🗄️ Schema Change: No Changes ✅

github-actions · 2026-04-01T00:07:59Z

Size Change: +77 B (+0.02%)

Total Size: 502 kB

📦 View Changed

Filename	Size	Change
`packages/perseus-score/dist/es/index.js`	9.78 kB	+77 B (+0.79%)

ℹ️ View Unchanged

Filename	Size
`packages/kas/dist/es/index.js`	20.6 kB
`packages/keypad-context/dist/es/index.js`	1 kB
`packages/kmath/dist/es/index.js`	6.36 kB
`packages/math-input/dist/es/index.js`	98.5 kB
`packages/math-input/dist/es/strings.js`	1.61 kB
`packages/perseus-core/dist/es/index.item-splitting.js`	12 kB
`packages/perseus-core/dist/es/index.js`	25.2 kB
`packages/perseus-editor/dist/es/index.js`	102 kB
`packages/perseus-linter/dist/es/index.js`	9.42 kB
`packages/perseus-utils/dist/es/index.js`	403 B
`packages/perseus/dist/es/index.js`	198 kB
`packages/perseus/dist/es/strings.js`	8.46 kB
`packages/pure-markdown/dist/es/index.js`	1.39 kB
`packages/simple-markdown/dist/es/index.js`	6.71 kB

_{compressed-size-action}

github-actions · 2026-04-01T00:08:06Z

🛠️ Item Splitting: No Changes ✅

github-actions · 2026-04-01T00:08:37Z

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (a26b8cf) and published it to npm. You
can install it using the tag PR3442.

Example:

pnpm add @khanacademy/perseus@PR3442

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3442

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3442

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

ivyolamit

@SonicScrewdriver overall looking good 👍🏼 I just have 1 non-blocking question.

ivyolamit · 2026-04-16T21:11:24Z

                    collinear(correct[1], correct[2], guess[2]);
            }

+            if (match) {


is this logic intentional?

Yeah! Github (or possibly Claude) is just weird about how it updates the code lines.

You'll notice that the same if (match) { logic continues below the Vector graph. Since this end logic is the same for every graph, sometimes it seems to think we've updated the previous graph.

ivyolamit · 2026-04-16T21:12:23Z

+            userInput.type === "vector" &&
+            rubric.correct.type === "vector" &&
+            userInput.coords != null &&
+            rubric.correct.coords != null


this is actually good point, do we want this also applied to other new graphs?

… Interactive Graphs

@benchristel

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-core@25.0.0 ### Major Changes - [#3511](#3511) [`15b0193db5`](15b0193) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused `static` field from PerseusCSProgramWidgetOptions. Callers should update test data that constructs `PerseusCSProgramWidgetOptions` to remove the static field. ### Minor Changes - [#3441](#3441) [`de45286302`](de45286) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of new Vector graph and subcomponents. - [#3433](#3433) [`b4bb6e2f42`](b4bb6e2) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of initial types and stubs for Vector graph ### Patch Changes - [#3434](#3434) [`de2dda0258`](de2dda0) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Implementation of state management logic for new Vector graph - Updated dependencies \[[`a5b9105c28`](a5b9105)]: - @khanacademy/kas@2.2.2 ## @khanacademy/perseus@77.3.0 ### Minor Changes - [#3441](#3441) [`de45286302`](de45286) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of new Vector graph and subcomponents. - [#3433](#3433) [`b4bb6e2f42`](b4bb6e2) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of initial types and stubs for Vector graph - [#3494](#3494) [`8fb79829d0`](8fb7982) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Interactive Graph: change asymptote line to dashed for both exponential and logarithm based on user feedback ### Patch Changes - [#3523](#3523) [`c89cdbe2aa`](c89cdbe) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Ensure the default coords for Exponential and Logarithm are slightly further away from the asymptote. - [#3508](#3508) [`16f7f77ba1`](16f7f77) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Give explore modal launcher a label saying it has description - [#3496](#3496) [`4d923417cd`](4d92341) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Add fallback label to Numeric Inputs and a linter warning for missing labels in the editor. - [#3511](#3511) [`15b0193db5`](15b0193) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused `static` field from PerseusCSProgramWidgetOptions. Callers should update test data that constructs `PerseusCSProgramWidgetOptions` to remove the static field. - [#3504](#3504) [`b8178b52e7`](b8178b5) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (a11y) | Add aria-describedby to Explore Image modal - [#3488](#3488) [`3abc5e8277`](3abc5e8) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - [Free Response] Add visual regression tests - [#3493](#3493) [`11742c2cff`](11742c2) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Implementing bug fix for jumping MovableLines in the Correct Answer graph in the editor - [#3483](#3483) [`7794943ec7`](7794943) Thanks [@nishasy](https://github.com/nishasy)! - [ColorSync] Numeric Input - update visual regression tests - [#3434](#3434) [`de2dda0258`](de2dda0) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Implementation of state management logic for new Vector graph - Updated dependencies \[[`de45286302`](de45286), [`4d923417cd`](4d92341), [`15b0193db5`](15b0193), [`b4bb6e2f42`](b4bb6e2), [`d3ef4dbcc2`](d3ef4db), [`a5b9105c28`](a5b9105), [`de2dda0258`](de2dda0)]: - @khanacademy/perseus-core@25.0.0 - @khanacademy/perseus-linter@4.9.5 - @khanacademy/perseus-score@8.7.0 - @khanacademy/kas@2.2.2 - @khanacademy/keypad-context@3.2.44 - @khanacademy/kmath@2.4.2 - @khanacademy/math-input@26.4.15 ## @khanacademy/perseus-editor@30.4.0 ### Minor Changes - [#3441](#3441) [`de45286302`](de45286) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of new Vector graph and subcomponents. - [#3443](#3443) [`a3396604a7`](a339660) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of new Vector Graph Editor - [#3433](#3433) [`b4bb6e2f42`](b4bb6e2) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of initial types and stubs for Vector graph - [#3492](#3492) [`883133a28f`](883133a) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Add preview data sanitizer to strip non-serializable values before postMessage ### Patch Changes - [#3522](#3522) [`19911cc966`](19911cc) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Label absolute-value graph start coordinates as "Vertex" and "Arm" in the editor instead of "Point 1" and "Point 2". - [#3505](#3505) [`1ab914fc41`](1ab914f) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Add warning for large images - [#3530](#3530) [`b5e918e8b3`](b5e918e) Thanks [@nishasy](https://github.com/nishasy)! - [Image] Update copy of recalculate button in editor - [#3434](#3434) [`de2dda0258`](de2dda0) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Implementation of state management logic for new Vector graph - Updated dependencies \[[`de45286302`](de45286), [`c89cdbe2aa`](c89cdbe), [`16f7f77ba1`](16f7f77), [`4d923417cd`](4d92341), [`15b0193db5`](15b0193), [`b8178b52e7`](b8178b5), [`b4bb6e2f42`](b4bb6e2), [`d3ef4dbcc2`](d3ef4db), [`3abc5e8277`](3abc5e8), [`a5b9105c28`](a5b9105), [`11742c2cff`](11742c2), [`7794943ec7`](7794943), [`de2dda0258`](de2dda0), [`8fb79829d0`](8fb7982)]: - @khanacademy/perseus@77.3.0 - @khanacademy/perseus-core@25.0.0 - @khanacademy/perseus-linter@4.9.5 - @khanacademy/perseus-score@8.7.0 - @khanacademy/kas@2.2.2 - @khanacademy/keypad-context@3.2.44 - @khanacademy/kmath@2.4.2 - @khanacademy/math-input@26.4.15 ## @khanacademy/perseus-score@8.7.0 ### Minor Changes - [#3442](#3442) [`d3ef4dbcc2`](d3ef4db) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Added ability to score Vector Interactive Graphs ### Patch Changes - Updated dependencies \[[`de45286302`](de45286), [`15b0193db5`](15b0193), [`b4bb6e2f42`](b4bb6e2), [`a5b9105c28`](a5b9105), [`de2dda0258`](de2dda0)]: - @khanacademy/perseus-core@25.0.0 - @khanacademy/kas@2.2.2 - @khanacademy/kmath@2.4.2 ## @khanacademy/kas@2.2.2 ### Patch Changes - [#3503](#3503) [`a5b9105c28`](a5b9105) Thanks [@benchristel](https://github.com/benchristel)! - Expressions are now compared more thoroughly. Now we always check that the expressions evaluate the same with all variables bound to -1, 0, and 1. We also check more randomly-chosen values: 28 instead of 12. ## @khanacademy/keypad-context@3.2.44 ### Patch Changes - Updated dependencies \[[`de45286302`](de45286), [`15b0193db5`](15b0193), [`b4bb6e2f42`](b4bb6e2), [`de2dda0258`](de2dda0)]: - @khanacademy/perseus-core@25.0.0 ## @khanacademy/kmath@2.4.2 ### Patch Changes - Updated dependencies \[[`de45286302`](de45286), [`15b0193db5`](15b0193), [`b4bb6e2f42`](b4bb6e2), [`de2dda0258`](de2dda0)]: - @khanacademy/perseus-core@25.0.0 ## @khanacademy/math-input@26.4.15 ### Patch Changes - Updated dependencies \[[`de45286302`](de45286), [`15b0193db5`](15b0193), [`b4bb6e2f42`](b4bb6e2), [`de2dda0258`](de2dda0)]: - @khanacademy/perseus-core@25.0.0 - @khanacademy/keypad-context@3.2.44 ## @khanacademy/perseus-linter@4.9.5 ### Patch Changes - [#3496](#3496) [`4d923417cd`](4d92341) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Add fallback label to Numeric Inputs and a linter warning for missing labels in the editor. - Updated dependencies \[[`de45286302`](de45286), [`15b0193db5`](15b0193), [`b4bb6e2f42`](b4bb6e2), [`a5b9105c28`](a5b9105), [`de2dda0258`](de2dda0)]: - @khanacademy/perseus-core@25.0.0 - @khanacademy/kas@2.2.2 - @khanacademy/kmath@2.4.2

SonicScrewdriver self-assigned this Apr 1, 2026

SonicScrewdriver added the olc-5.0.c4fcb label Apr 1, 2026

SonicScrewdriver changed the title ~~docs(changeset): Added ability to score Vector Interactive Graphs~~ [ Interactive Graph | Vector Graph ] PR4: Scoring Apr 1, 2026

SonicScrewdriver force-pushed the LEMS-3971/vector-pr3 branch from 77f5629 to 52d299e Compare April 7, 2026 19:52

SonicScrewdriver force-pushed the LEMS-3971/vector-pr4 branch 2 times, most recently from 3186d72 to 37f9aa6 Compare April 7, 2026 20:10

SonicScrewdriver force-pushed the LEMS-3971/vector-pr3 branch from 8e83938 to cec842e Compare April 9, 2026 22:23

SonicScrewdriver force-pushed the LEMS-3971/vector-pr4 branch 2 times, most recently from c074d48 to 4f81f2b Compare April 13, 2026 20:43

SonicScrewdriver force-pushed the LEMS-3971/vector-pr3 branch from acb02ad to 3e10b58 Compare April 13, 2026 21:17

SonicScrewdriver force-pushed the LEMS-3971/vector-pr4 branch from 4f81f2b to 9df7edc Compare April 13, 2026 21:21

SonicScrewdriver force-pushed the LEMS-3971/vector-pr3 branch from 3e10b58 to 8b59475 Compare April 15, 2026 22:10

SonicScrewdriver force-pushed the LEMS-3971/vector-pr4 branch 2 times, most recently from 22d9919 to bb050ee Compare April 15, 2026 22:19

SonicScrewdriver force-pushed the LEMS-3971/vector-pr3 branch from bd44dd3 to 0c99f50 Compare April 15, 2026 22:26

SonicScrewdriver force-pushed the LEMS-3971/vector-pr4 branch 2 times, most recently from 599b46a to 4dd7d4e Compare April 15, 2026 23:22

SonicScrewdriver marked this pull request as ready for review April 15, 2026 23:42

claude Bot reviewed Apr 15, 2026

View reviewed changes

ivyolamit approved these changes Apr 16, 2026

View reviewed changes

SonicScrewdriver force-pushed the LEMS-3971/vector-pr3 branch from cee09bc to 8ae7021 Compare April 16, 2026 22:13

SonicScrewdriver force-pushed the LEMS-3971/vector-pr4 branch from 4dd7d4e to 097ccb9 Compare April 16, 2026 22:20

SonicScrewdriver force-pushed the LEMS-3971/vector-pr3 branch 2 times, most recently from 96c02a8 to 8d5361d Compare April 28, 2026 01:13

SonicScrewdriver changed the base branch from LEMS-3971/vector-pr3 to main April 28, 2026 01:22

An error occurred while trying to automatically change base from LEMS-3971/vector-pr3 to main April 28, 2026 01:22

SonicScrewdriver added 2 commits April 27, 2026 18:24

[LEMS-3971/vector-pr4] docs(changeset): Added ability to score Vector…

a5618a9

… Interactive Graphs

[LEMS-3971/vector-pr4] allow congruent scoring

a26b8cf

SonicScrewdriver force-pushed the LEMS-3971/vector-pr4 branch from 097ccb9 to a26b8cf Compare April 28, 2026 01:24

SonicScrewdriver merged commit d3ef4db into main Apr 28, 2026
11 checks passed

khan-actions-bot mentioned this pull request Apr 28, 2026

Version Packages #3498

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ Interactive Graph | Vector Graph ] PR4: Scoring#3442

[ Interactive Graph | Vector Graph ] PR4: Scoring#3442
SonicScrewdriver merged 2 commits intomainfrom
LEMS-3971/vector-pr4

SonicScrewdriver commented Apr 1, 2026 •

edited by atlassian Bot

Loading

Uh oh!

github-actions Bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

claude Bot left a comment

Uh oh!

ivyolamit left a comment

Uh oh!

ivyolamit Apr 16, 2026

Uh oh!

SonicScrewdriver Apr 16, 2026

Uh oh!

ivyolamit Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

SonicScrewdriver commented Apr 1, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes:

Test plan:

Uh oh!

github-actions Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗄️ Schema Change: No Changes ✅

Uh oh!

github-actions Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠️ Item Splitting: No Changes ✅

Uh oh!

github-actions Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

npm Snapshot: Published

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

ivyolamit left a comment

Choose a reason for hiding this comment

Uh oh!

ivyolamit Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

SonicScrewdriver Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ivyolamit Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SonicScrewdriver commented Apr 1, 2026 •

edited by atlassian Bot

Loading

github-actions Bot commented Apr 1, 2026 •

edited

Loading

github-actions Bot commented Apr 1, 2026 •

edited

Loading

github-actions Bot commented Apr 1, 2026 •

edited

Loading

github-actions Bot commented Apr 1, 2026 •

edited

Loading