Fix global schema lookup on Windows#36
Open
AJDurant wants to merge 1 commit into
Open
Conversation
When using the glob match `./dir/*.md` on Windows, it gets transformed to `dir\\*.md` by the path normalization. minimatch specifically says not to use `\` or `\\` as these are easy to mess up escaping, and the above transformation does not match when you would expect it to. The solution is to always use `/` for the glob, or to ignore the escapes on Windows with the `windowsPathsNoEscape` option. https://github.com/isaacs/minimatch?tab=readme-ov-file#windows Given the normalization is needed for sorting out relative paths, using the `windowsPathsNoEscape` option makes most sense. I've tested this locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the glob match
./dir/*.mdon Windows, it gets transformed todir\\*.mdby the path normalization.minimatch specifically says not to use
\or\\as these are easy to mess up escaping, and the above transformation does not match when you would expect it to.The solution is to always use
/for the glob, or to ignore the escapes on Windows with thewindowsPathsNoEscapeoption. https://github.com/isaacs/minimatch?tab=readme-ov-file#windowsGiven the normalization is needed for sorting out relative paths, using the
windowsPathsNoEscapeoption makes most sense. I've tested this locally.