Tweak wording for finite_domainerror

[christiangnrd]

Per @yuyichao's recommendation #944 (comment)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.63%. Comparing base (8b4fcb1) to head (d1352a8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   86.72%   86.63%   -0.09%     
==========================================
  Files          77       77              
  Lines        5483     5486       +3     
==========================================
- Hits         4755     4753       -2     
- Misses        728      733       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Metal Benchmarks

Details

Benchmark suite	Current: d1352a8	Previous: 8b4fcb1	Ratio
array/accumulate/Float32/1d	403375 ns	357292 ns	1.13
array/accumulate/Float32/dims=1	377583 ns	384625 ns	0.98
array/accumulate/Float32/dims=1L	8811125 ns	8813292 ns	1.00
array/accumulate/Float32/dims=2	441542 ns	444084 ns	0.99
array/accumulate/Float32/dims=2L	2158250 ns	2747834 ns	0.79
array/accumulate/Int64/1d	845584 ns	847875 ns	1.00
array/accumulate/Int64/dims=1	932500 ns	940125 ns	0.99
array/accumulate/Int64/dims=1L	9529708 ns	9530250 ns	1.00
array/accumulate/Int64/dims=2	1252833 ns	1076042 ns	1.16
array/accumulate/Int64/dims=2L	6531083 ns	6532458 ns	1.00
array/broadcast	233584 ns	193458 ns	1.21
array/construct	2125 ns	2166 ns	0.98
array/permutedims/2d	546291 ns	546250 ns	1.00
array/permutedims/3d	1003709 ns	999333 ns	1.00
array/permutedims/4d	1231375 ns	1253000 ns	0.98
array/private/copy	235875 ns	240375 ns	0.98
array/private/copyto!/cpu_to_gpu	196500 ns	194500 ns	1.01
array/private/copyto!/gpu_to_cpu	195000 ns	191417 ns	1.02
array/private/copyto!/gpu_to_gpu	198125 ns	204250 ns	0.97
array/private/iteration/findall/bool	1079667 ns	1076458 ns	1.00
array/private/iteration/findall/int	1218125 ns	1228292 ns	0.99
array/private/iteration/findfirst/bool	1103417 ns	1098292 ns	1.00
array/private/iteration/findfirst/int	933750 ns	1115125 ns	0.84
array/private/iteration/findmin/1d	1238084 ns	1242459 ns	1.00
array/private/iteration/findmin/2d	1073209 ns	1085250 ns	0.99
array/private/iteration/logical	1740250 ns	1724708 ns	1.01
array/private/iteration/scalar	1152209 ns	1168875 ns	0.99
array/random/rand/Float32	397458 ns	433042 ns	0.92
array/random/rand/Int64	523084 ns	519083 ns	1.01
array/random/rand!/Float32	370458 ns	377334 ns	0.98
array/random/rand!/Int64	402375 ns	401959 ns	1.00
array/random/randn/Float32	390250 ns	387334 ns	1.01
array/random/randn!/Float32	290083 ns	284833 ns	1.02
array/reductions/mapreduce/Float32/1d	404000 ns	401334 ns	1.01
array/reductions/mapreduce/Float32/dims=1	330375 ns	330333 ns	1.00
array/reductions/mapreduce/Float32/dims=1L	630583 ns	636625 ns	0.99
array/reductions/mapreduce/Float32/dims=2	330208 ns	290750 ns	1.14
array/reductions/mapreduce/Float32/dims=2L	1004625 ns	1005334 ns	1.00
array/reductions/mapreduce/Int64/1d	584792 ns	592250 ns	0.99
array/reductions/mapreduce/Int64/dims=1	453166 ns	617459 ns	0.73
array/reductions/mapreduce/Int64/dims=1L	1034500 ns	1035750 ns	1.00
array/reductions/mapreduce/Int64/dims=2	788041 ns	672750 ns	1.17
array/reductions/mapreduce/Int64/dims=2L	2182292 ns	2198000 ns	0.99
array/reductions/reduce/Float32/1d	396292 ns	404750 ns	0.98
array/reductions/reduce/Float32/dims=1	334625 ns	283458 ns	1.18
array/reductions/reduce/Float32/dims=1L	632042 ns	635500 ns	0.99
array/reductions/reduce/Float32/dims=2	233125 ns	244625 ns	0.95
array/reductions/reduce/Float32/dims=2L	461375 ns	460500 ns	1.00
array/reductions/reduce/Int64/1d	585916 ns	600584 ns	0.98
array/reductions/reduce/Int64/dims=1	621833 ns	618042 ns	1.01
array/reductions/reduce/Int64/dims=1L	1025084 ns	1035958 ns	0.99
array/reductions/reduce/Int64/dims=2	243542 ns	217500 ns	1.12
array/reductions/reduce/Int64/dims=2L	652959 ns	663250 ns	0.98
array/shared/copy	136459 ns	135958 ns	1.00
array/shared/copyto!/cpu_to_gpu	37667 ns	37084 ns	1.02
array/shared/copyto!/gpu_to_cpu	38333 ns	38958 ns	0.98
array/shared/copyto!/gpu_to_gpu	38583 ns	38916 ns	0.99
array/shared/iteration/findall/bool	1092625 ns	999666 ns	1.09
array/shared/iteration/findall/int	1245459 ns	1242875 ns	1.00
array/shared/iteration/findfirst/bool	812959 ns	812000 ns	1.00
array/shared/iteration/findfirst/int	927791 ns	857833 ns	1.08
array/shared/iteration/findmin/1d	1102042 ns	890625 ns	1.24
array/shared/iteration/findmin/2d	1079750 ns	1083417 ns	1.00
array/shared/iteration/logical	1571834 ns	1587292 ns	0.99
array/shared/iteration/scalar	3640.625 ns	3698 ns	0.98
array/sorting/1d	1797750 ns	1828875 ns	0.98
array/sorting/2d	8307042 ns	8308916 ns	1.00
integration/byval/reference	1118708 ns	1117584 ns	1.00
integration/byval/slices=1	1115125 ns	1119209 ns	1.00
integration/byval/slices=2	2034458 ns	2028792 ns	1.00
integration/byval/slices=3	7373083 ns	6714167 ns	1.10
integration/metaldevrt	318666 ns	371000 ns	0.86
kernel/indexing	185334 ns	186291 ns	0.99
kernel/indexing_checked	309667 ns	365834 ns	0.85
kernel/launch	1904.1 ns	1895.8 ns	1.00
kernel/rand	375125 ns	349208 ns	1.07
latency/import	2147204791 ns	2136332291 ns	1.01
latency/precompile	42319399500 ns	42191927875 ns	1.00
latency/ttfp	2469106166 ns	2462083334 ns	1.00
metal/synchronization/context	651.170731707317 ns	659.9378881987577 ns	0.99
metal/synchronization/stream	337.1181818181818 ns	338.8009049773756 ns	1.00

This comment was automatically generated by workflow using github-action-benchmark.