Skip to content

Fix/example tableview #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisIsTheFoxe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/example tableview #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9381113
Fix example table view textfield
thisIsTheFoxe Oct 3, 2022
4c09c66
Fix collection/table-view hidden views shown briefly
thisIsTheFoxe Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Examples/iOS Example/Sources/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ extension ViewController: SkeletonTableViewDataSource {
func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
let cell = tableView.dequeueReusableCell(withIdentifier: "CellIdentifier", for: indexPath) as! Cell
cell.label1.text = "cell -> \(indexPath.row)"
cell.textField.isHidden = indexPath.row == 0
return cell
}

Expand Down
4 changes: 3 additions & 1 deletion SkeletonViewCore/Sources/Internal/UIKitExtensions/UIView+Transitions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ extension UIView {

func startTransition(transitionBlock: @escaping () -> Void) {
guard let transitionStyle = _currentSkeletonConfig?.transition,
transitionStyle != .none else {
transitionStyle != .none,
// transition causes hidden view to show
!isHidden else {
transitionBlock()
return
}
Expand Down