CI: Switch from aiida-testing to aiida-test-cache#214
Open
danielhollas wants to merge 8 commits into
Open
Conversation
danielhollas
commented
Dec 6, 2024
| pip install .[testing,graphs] | ||
| pip install ${{ matrix.aiida.version }} ${{ matrix.masci-tools.version }} | ||
| pip install ${{ matrix.bokeh-version }} ${{ matrix.mpl-version }} | ||
| reentry scan || true |
Author
There was a problem hiding this comment.
You no longer test with aiida-core v1 so this is not needed.
PhilippRue
approved these changes
Dec 12, 2024
Member
PhilippRue
left a comment
PhilippRue
left a comment
There was a problem hiding this comment.
This should be fine, I did it in the same way in aiida-kkr where aiida-test-cache is now a proper dependency. Thanks @danielhollas for the effort
PhilippRue
added
dependencies
Author
|
@PhilippRue thanks! Are you able to approve the workflow run in this repo? That way we'll see if the tests work.
|
Member
Yes it runs and the failing tests were also failing before, they didn't break with this change. |
aiida-testing pytest plugin has been renamed to aiida-test-cache and published on PyPI we can drop the dependency on Git repo. The released version should be fully backwards compatible, see release notes: https://github.com/aiidateam/aiida-test-cache/releases/tag/v0.0.1
danielhollas
force-pushed
the
aiida-test-cache
branch
from
bc678dd to
5ef5ffc
Compare
danielhollas
force-pushed
the
aiida-test-cache
branch
from
5ef5ffc to
24da182
Compare
Author
|
@PhilippRue could this be merged? (I also fixed the RTD docs build here) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
I've been recently updating the the aiida-testing package that you use here for regression tests.
As part of that work,
aiida-testingpytest plugin has been renamed toaiida-test-cacheand published on PyPI so you can drop the dependency on Git repo.The released version should be fully backwards compatible, see release notes:
https://github.com/aiidateam/aiida-test-cache/releases/tag/v0.0.1