Skip to content

Add bugfix (unrelased) notes for the tuple-indexed variables + constraint_detection=True issue#146

Merged
konn merged 5 commits intodevelopfrom
kory33/egglog-constraint-subscript-eval
Apr 21, 2026
Merged

Add bugfix (unrelased) notes for the tuple-indexed variables + constraint_detection=True issue#146
konn merged 5 commits intodevelopfrom
kory33/egglog-constraint-subscript-eval

Conversation

@kory33-jij
Copy link
Copy Markdown
Contributor

No description provided.

@kory33-jij kory33-jij changed the title Kory33/egglog constraint subscript eval Add bugfix (unrelased) notes for the tuple-indexed variables + constraint_detection=True issue Apr 21, 2026
Copy link
Copy Markdown
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textlint の CI が落ちていますね。textlint extension を入れるとルールに従って保存時に直してくれるので楽です。また、制約検出はデフォルトでは ON であることに注意して若干書き直してみるとよさそうです。

Comment thread markdowns/ja/releases/unreleased.md Outdated
Comment thread markdowns/en/releases/unreleased.md Outdated
Co-authored-by: Copilot <copilot@github.com>
@kory33-jij kory33-jij requested a review from konn April 21, 2026 08:57
Copy link
Copy Markdown
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とおもったら unreleased.md と ipynb のどちらかの sync が取れてなさそうですね……

@kory33-jij
Copy link
Copy Markdown
Contributor Author

慣れていない 😇 更新しました 🙏

Copy link
Copy Markdown
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@konn konn merged commit 69b955d into develop Apr 21, 2026
6 of 24 checks passed
@konn konn deleted the kory33/egglog-constraint-subscript-eval branch April 21, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants