[KT-85690] Fixing deserialization and serialization on jklib pipeline so it actually runs#5892
Merged
KotlinBuild merged 1 commit intomasterfrom Apr 21, 2026
Conversation
Code Owners
|
zardilior
force-pushed
the
zardilior/fixing-deserialization-and-serialization-on-jklib-pipeline
branch
2 times, most recently
from
16c6829 to
6bdf902
Compare
zardilior
changed the title
zardilior
commented
Apr 18, 2026
| ) | ||
|
|
||
| val compilationArtifact = JKlibIrCompilationPhase.invokeToplevel(phaseConfig, context, serializationArtifact) | ||
| val compilationArtifact = JKlibIrCompilationPhase.executePhase(serializationArtifact) |
Collaborator
Author
There was a problem hiding this comment.
Using executePhase is better than using invokeTopLevel in the facades, this leverages the natural pipeline structure for error handling. And its consistent with other facades.
We are changing this in both Facades serialization, SerializationCliJKlibFacade.kt, and deserialization, JKlibIrCompilationCliFacade.kt.
zardilior
commented
Apr 18, 2026
zardilior
commented
Apr 18, 2026
This was referenced Apr 18, 2026
jDramaix
reviewed
Apr 20, 2026
demiurg906
requested changes
Apr 20, 2026
jDramaix
reviewed
Apr 20, 2026
| // ^^^^ member scope of kotlin.Int is different for JVM and JKlib stdlibs | ||
|
|
||
| val test = Int.MIN_VALUE | ||
| val test = Int.MIN_VALUE No newline at end of file |
Collaborator
There was a problem hiding this comment.
Nits: missing new line at the end of the file
jDramaix
approved these changes
Apr 20, 2026
demiurg906
approved these changes
Apr 21, 2026
Collaborator
|
/safe-merge --fixup |
kotlin-safe-merge
Bot
force-pushed
the
zardilior/fixing-deserialization-and-serialization-on-jklib-pipeline
branch
from
05a7277 to
6932c1f
Compare
|
Quality gate is triggered at https://buildserver.labs.intellij.net/build/931464799 — use this link to get full insight. Quality gate was triggered with the following revisions:
|
|
Triggered a retry attempt №1 out of 1. |
|
Quality gate finished successfully (recovered via retry). |
KotlinBuild
deleted the
zardilior/fixing-deserialization-and-serialization-on-jklib-pipeline
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently the serialization and deserialization phases, though declared in the test pipeline doesn't run.
This is due to global defaults not having the right artifact kind which is important for backend phases like deserialization as well as these phases not declaring the right type.
Solution
State Artifact.KLib as the defaultArtifact in global imports and casting in facades and between phases as necessary.
Additional Fix
Using invokeTopLevel in the Facades, rather than using executePhase throws when phases return null but shows no errors.
We are changing this in both Facades:
serialization, SerializationCliJKlibFacade.kt, and deserialization, JKlibIrCompilationCliFacade.kt
It also matches how other Facades in other pipelines work