KT-69909: A few commonizer-related fixes by lunakoly · Pull Request #5888 · JetBrains/kotlin

lunakoly · 2026-04-17T13:02:32Z

No description provided.

kodee-bot · 2026-04-17T13:02:36Z

Hi! It looks like there are no references to any YT issues in the commit messages.
If the change is non-functional, feel free to resolve the comment :)
Otherwise, please add them as requested in the guideline.

kotlin-safe-merge · 2026-04-17T13:02:37Z

Code Owners

Rule	Owners	Approval
`*Generated.java`		✅ `@demiurg906`, `@vsukharev`
`/compiler/fir/`, `/compiler/testData/diagnostics/`	kotlin-frontend `@ligee` `@dzharkov` `@bnorm` `@mglukhikh` `@KvanTTT` `@cypressious` `@demiurg906` `@FenstonSingel` `@lunakoly` `@agamzikova` `@GrigoriiSolnyshkin` `@Aleksandra-Arsenteva`	✅ `@demiurg906`
`/native/native.tests/klib-ir-inliner/`	kotlin-common-backend `@vsukharev` `@kunyavskiy` `@ivandev0` `@AnzhelaSukhanova` `@mcpiroman` `@ddolovov` `@mpiekutowski`	✅ `@vsukharev`

kodee-bot · 2026-04-17T13:05:10Z

Please Review and Extend Test Coverage.
This merge request references a Feature-type ticket. As this introduces or extends functionality,
please ensure that test coverage is sufficiently comprehensive.

vsukharev · 2026-04-17T14:57:18Z

I wonder, what's the general function of FirFailingTestSuppressor?
I'm trying to remove it from here, and from other testrunners, like AbstractJsDiagnosticTestBase. Tests are still green, whilst I'd expected at least one to fail and take a look there

It's a thing for test files where the compiler crashes with an exception. Normally, these failures mean the test fails, but FirFailingTestSuppressor allows providing an additional .fir.fail file (which is supposed to contain the exception stacktrace) to make the test "green".

Under this interpretation, a test is expected to be green iff the compiler works the way we expect it to, properly or not.

It allows suppressing the test by creating a .fail file, if the exception from the frontend was thrown. I think it's not needed in tests which supports suppressing by some more general means, like // IGNORE_BACKEND.

I'd argue that it still is because it allows to present the entire stacktrace instead of forcing the author describe anything in the commit message 🤷

lunakoly · 2026-04-21T12:30:58Z

/safe-merge --fixup

kotlin-safe-merge · 2026-04-21T12:31:02Z

Command rejected: No fixup! commits found on the branch.

lunakoly · 2026-04-21T12:31:25Z

/safe-merge

KotlinBuild · 2026-04-21T12:36:16Z

Quality gate is triggered at https://buildserver.labs.intellij.net/build/931481442 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5888/safe-merge
Commit: eea2f83

KotlinBuild · 2026-04-21T14:00:30Z

Triggered a retry attempt №1 out of 1.

KotlinBuild · 2026-04-21T14:29:43Z

Quality gate failed. See https://buildserver.labs.intellij.net/build/931481442 to get full insight.

New changes affect files owned by this reviewer. Re-review required.

lunakoly · 2026-04-22T09:09:25Z

/safe-merge

kotlin-safe-merge · 2026-04-22T09:09:29Z

Command rejected: Commit 'fixup!' is currently not supported by GitHub - please try /fixup command or /safe-squash-merge

lunakoly · 2026-04-22T09:09:50Z

/safe-merge --fixup

...when resolving the symbol from an expect class lookup tag. ^KT-41509

^KT-41509

KotlinBuild · 2026-04-22T09:11:22Z

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932183496 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5888/safe-merge
Commit: d125c7b

KotlinBuild · 2026-04-22T10:40:00Z

Triggered a retry attempt №1 out of 1.

KotlinBuild · 2026-04-22T11:10:35Z

Quality gate failed. See https://buildserver.labs.intellij.net/build/932183496 to get full insight.

^KT-41509

New changes affect files owned by this reviewer. Re-review required.

lunakoly · 2026-04-22T13:19:49Z

/safe-merge

KotlinBuild · 2026-04-22T13:23:55Z

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932423895 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5888/safe-merge
Commit: f1bb40b

KotlinBuild · 2026-04-22T14:55:31Z

Quality gate finished successfully.

lunakoly requested a review from demiurg906 April 17, 2026 13:02

lunakoly requested a review from kunyavskiy April 17, 2026 13:03

KotlinBuild force-pushed the rr/lunakoly/kt69909-bug-with-lookuptag-to-symbol-call branch from 4042d53 to ce58123 Compare April 17, 2026 13:05

kunyavskiy requested review from vsukharev and removed request for kunyavskiy April 17, 2026 13:05

vsukharev reviewed Apr 17, 2026

View reviewed changes

lunakoly requested a review from vsukharev April 20, 2026 07:40

demiurg906 requested changes Apr 20, 2026

View reviewed changes

Comment thread ...a/diagnostics/nativeTests/multiplatform/containingClassSymbolWithWrongModuleDataBug.fir.fail Outdated

vsukharev approved these changes Apr 20, 2026

View reviewed changes

KotlinBuild force-pushed the rr/lunakoly/kt69909-bug-with-lookuptag-to-symbol-call branch from ce58123 to a8b1b0d Compare April 20, 2026 09:37

lunakoly requested a review from demiurg906 April 20, 2026 09:42

demiurg906 previously approved these changes Apr 20, 2026

View reviewed changes

kotlin-safe-merge Bot requested a review from demiurg906 April 22, 2026 08:17

demiurg906 previously approved these changes Apr 22, 2026

View reviewed changes

lunakoly added 2 commits April 22, 2026 09:09

[FIR] Reproduce the failure caused by the use of the wrong session...

d7a5353

...when resolving the symbol from an expect class lookup tag. ^KT-41509

[FIR] Fix the bug repdocued in the previous commit

df43057

^KT-41509

kotlin-safe-merge Bot force-pushed the rr/lunakoly/kt69909-bug-with-lookuptag-to-symbol-call branch from 6350632 to e5aba76 Compare April 22, 2026 09:10

[FIR] Fix a false-positive CONFLICTING_OVERLOADS in KMP

9583bc9

^KT-41509

KotlinBuild force-pushed the rr/lunakoly/kt69909-bug-with-lookuptag-to-symbol-call branch from e5aba76 to 9583bc9 Compare April 22, 2026 12:46

kotlin-safe-merge Bot requested a review from demiurg906 April 22, 2026 12:46

demiurg906 approved these changes Apr 22, 2026

View reviewed changes

KotlinBuild merged commit 8233e6d into master Apr 22, 2026
1 check passed

KotlinBuild deleted the rr/lunakoly/kt69909-bug-with-lookuptag-to-symbol-call branch April 22, 2026 14:55

Conversation

lunakoly commented Apr 17, 2026

Uh oh!

kodee-bot Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kotlin-safe-merge Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Owners

Uh oh!

kodee-bot Bot commented Apr 17, 2026

Uh oh!

vsukharev Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

lunakoly Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

demiurg906 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

lunakoly Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lunakoly commented Apr 21, 2026

Uh oh!

kotlin-safe-merge Bot commented Apr 21, 2026

Uh oh!

lunakoly commented Apr 21, 2026

Uh oh!

KotlinBuild commented Apr 21, 2026

Uh oh!

KotlinBuild commented Apr 21, 2026

Uh oh!

KotlinBuild commented Apr 21, 2026

Uh oh!

lunakoly commented Apr 22, 2026

Uh oh!

kotlin-safe-merge Bot commented Apr 22, 2026

Uh oh!

lunakoly commented Apr 22, 2026

Uh oh!

KotlinBuild commented Apr 22, 2026

Uh oh!

KotlinBuild commented Apr 22, 2026

Uh oh!

KotlinBuild commented Apr 22, 2026

Uh oh!

lunakoly commented Apr 22, 2026

Uh oh!

KotlinBuild commented Apr 22, 2026

Uh oh!

KotlinBuild commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kodee-bot Bot commented Apr 17, 2026 •

edited

Loading

kotlin-safe-merge Bot commented Apr 17, 2026 •

edited

Loading