Skip to content

[FIR] Allow companion property with initializer in interfaces KT-85770#5881

Merged
KotlinBuild merged 1 commit intomasterfrom
krakhman/companion_prop_in_interface
Apr 20, 2026
Merged

[FIR] Allow companion property with initializer in interfaces KT-85770#5881
KotlinBuild merged 1 commit intomasterfrom
krakhman/companion_prop_in_interface

Conversation

@cypressious
Copy link
Copy Markdown
Contributor

@cypressious cypressious commented Apr 16, 2026

No description provided.

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 16, 2026

Code Owners

Rule Owners Approval
/​compiler/​fir/​, /​compiler/​testData/​diagnostics/​ kotlin-frontend
@lunakoly

@cypressious cypressious requested a review from lunakoly April 16, 2026 14:23
@@ -0,0 +1,11 @@
// RUN_PIPELINE_TILL: BACKEND
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no errors, I'd prefer to have this as a codegen box test instead, and also check that access to such property (both get and set) is generated correctly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call because it revealed KT-85853.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, so why are we merging support for something that doesn't work instead of making it work first?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable question. IMO, experimental features always need to exist in an incomplete state in master unless we want to drop them in one giant PR spanning multiple subsystems.

Case in point; the feature basically only works on the JVM right now.

Here, we're fixing the frontend part of this bug. The backend part has a separate ticket and will probably be fixed by your team. Unless we start doing stacked PRs, I don't see a nicer way to deliver these fixes.

@cypressious
Copy link
Copy Markdown
Contributor Author

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

Quality gate is triggered at https://buildserver.labs.intellij.net/build/930243934 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5881/safe-merge
Commit: 385fbf7

@KotlinBuild
Copy link
Copy Markdown

Quality gate finished successfully.

@KotlinBuild KotlinBuild merged commit 9dba6ab into master Apr 20, 2026
1 check passed
@KotlinBuild KotlinBuild deleted the krakhman/companion_prop_in_interface branch April 20, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants