Skip to content

[Swift Export] Resolve type parameter upper bounds#5880

Merged
KotlinBuild merged 1 commit intoJetBrains:masterfrom
rickclephas:bugfix/KT-85788-recursive-generic
Apr 21, 2026
Merged

[Swift Export] Resolve type parameter upper bounds#5880
KotlinBuild merged 1 commit intoJetBrains:masterfrom
rickclephas:bugfix/KT-85788-recursive-generic

Conversation

@rickclephas
Copy link
Copy Markdown
Contributor

^KT-85788 Fixed

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 16, 2026

Code Owners

Rule Owners Approval
/​native/​swift/​**/​*.​gradle.​kts kotlin-native
@mMaxy
/​native/​swift/​ @glukianets, @mMaxy
@mMaxy
/​repo/​ kotlin-build-infrastructure, @sellmair
@CristianGM

@rickclephas rickclephas marked this pull request as draft April 16, 2026 12:19
@rickclephas rickclephas force-pushed the bugfix/KT-85788-recursive-generic branch from 7d80b78 to 8a35f54 Compare April 16, 2026 14:17
@rickclephas rickclephas marked this pull request as ready for review April 16, 2026 14:18
mMaxy
mMaxy previously approved these changes Apr 16, 2026
@mMaxy
Copy link
Copy Markdown
Contributor

mMaxy commented Apr 16, 2026

/safe-merge

@kotlin-safe-merge
Copy link
Copy Markdown

Command rejected: Pull request has conflicts with the base branch that must be resolved before merging.

@rickclephas rickclephas force-pushed the bugfix/KT-85788-recursive-generic branch from 8a35f54 to 59b10da Compare April 17, 2026 06:52
@kotlin-safe-merge kotlin-safe-merge Bot dismissed mMaxy’s stale review April 17, 2026 06:52

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from mMaxy April 17, 2026 06:53
@mMaxy
Copy link
Copy Markdown
Contributor

mMaxy commented Apr 17, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

Quality gate is triggered at https://buildserver.labs.intellij.net/build/928491052 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5880/safe-merge
Commit: 59b10da

@KotlinBuild
Copy link
Copy Markdown

Triggered a retry attempt №1 out of 1.

@KotlinBuild
Copy link
Copy Markdown

Quality gate failed. See https://buildserver.labs.intellij.net/build/928491052 to get full insight.

@rickclephas rickclephas force-pushed the bugfix/KT-85788-recursive-generic branch from 59b10da to 49d70a7 Compare April 20, 2026 08:50
analysisSession: KaSession,
projection: KaTypeProjection,
typeRenderer: KaTypeRenderer,
printer: PrettyPrinter,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why PrettyPrinter is part of :analysis:analysis-internal-utils though

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was also surprised, but given the fact that it just leaked as a part of public API - decided not to say anything :)

@mMaxy mMaxy requested review from Badya and CristianGM and removed request for Badya April 20, 2026 13:15
@mMaxy
Copy link
Copy Markdown
Contributor

mMaxy commented Apr 21, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

Quality gate is triggered at https://buildserver.labs.intellij.net/build/931266464 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5880/safe-merge
Commit: 841c672

@KotlinBuild
Copy link
Copy Markdown

Quality gate finished successfully.

@KotlinBuild KotlinBuild merged commit 0b58c6a into JetBrains:master Apr 21, 2026
1 check passed
@rickclephas rickclephas deleted the bugfix/KT-85788-recursive-generic branch April 21, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants