[Wasm] Replace first stage test config with phased CLI infra (^KT-74671) by jmrtsh · Pull Request #5875 · JetBrains/kotlin

jmrtsh · 2026-04-16T08:37:52Z

~~Just creating this PR to be able to run CI - not finished yet.~~

Implements KT-74671, and tries to simplify things between Js and Wasm test configs as a result.

kotlin-safe-merge · 2026-04-16T08:37:58Z

Code Owners

Rule	Owners	Approval
`/compiler/cli/cli-js/`	kotlin-js `@JSMonk` `@broadwaylamb` `@seclerp` `@AnzhelaSukhanova` kotlin-wasm `@bashor` `@karlosz` `@ilgonmic` `@jmrtsh` `@igoriakovlev` `@agamzikova` `@alex28sh` `@ozzush`	✅ `@broadwaylamb` 🔒, `@alex28sh`
`/compiler/ir/serialization.common/`, `/wasm/wasm.tests/klib-compatibility/`	kotlin-common-backend `@vsukharev` `@kunyavskiy` `@ivandev0` `@AnzhelaSukhanova` `@mcpiroman` `@ddolovov` `@mpiekutowski`	✅ `@vsukharev`
`/compiler/ir/serialization.js/`, `/js/`	kotlin-js `@JSMonk` `@broadwaylamb` `@seclerp` `@AnzhelaSukhanova`	✅ `@broadwaylamb` 🔒
`/compiler/tests-common-new/`	kotlin-frontend `@ligee` `@dzharkov` `@bnorm` `@mglukhikh` `@KvanTTT` `@cypressious` `@demiurg906` `@FenstonSingel` `@lunakoly` `@agamzikova` `@GrigoriiSolnyshkin` `@Aleksandra-Arsenteva`	✅ `@demiurg906`
`/compiler/tests-common-new/testFixtures/org/jetbrains/kotlin/test/services/configuration/WasmEnvironmentConfigurator.kt`, `/wasm/`	kotlin-wasm `@bashor` `@karlosz` `@ilgonmic` `@jmrtsh` `@igoriakovlev` `@agamzikova` `@alex28sh` `@ozzush`	✅ `@alex28sh`
`/compiler/util-klib-abi/`	`@fzhinkin` kotlin-common-backend `@vsukharev` `@kunyavskiy` `@ivandev0` `@AnzhelaSukhanova` `@mcpiroman` `@ddolovov` `@mpiekutowski`	✅ `@vsukharev`

jmrtsh · 2026-04-16T08:39:20Z

/dry-run

jmrtsh · 2026-04-16T16:09:46Z

/dry-run

jmrtsh · 2026-04-17T09:42:10Z

/dry-run

KotlinBuild · 2026-04-17T11:56:48Z

Quality gate finished successfully (recovered via retry).

jmrtsh · 2026-04-20T10:30:54Z

/dry-run

jmrtsh · 2026-04-20T11:55:22Z

Looks like an unrelated CI failure about test federation, rebasing to latest green master and canceling the build.

jmrtsh · 2026-04-20T11:56:16Z

/dry-run

KotlinBuild · 2026-04-20T11:58:07Z

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/930403789 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5875/safe-merge
Commit: 330ad0b

KotlinBuild · 2026-04-20T14:12:31Z

Triggered a retry attempt №1 out of 1.

KotlinBuild · 2026-04-20T14:20:44Z

Quality gate finished successfully (recovered via retry).

jmrtsh · 2026-04-20T15:37:36Z

/dry-run

KotlinBuild · 2026-04-20T15:39:21Z

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/930661497 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5875/safe-merge
Commit: c532d6e

jmrtsh · 2026-04-20T16:21:55Z

/dry-run

KotlinBuild · 2026-04-20T16:23:36Z

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/930732003 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5875/safe-merge
Commit: 009ae1f

KotlinBuild · 2026-04-20T17:42:04Z

Triggered a retry attempt №1 out of 1.

KotlinBuild · 2026-04-20T18:10:16Z

Triggered a retry attempt №1 out of 1.

jmrtsh · 2026-04-27T12:57:29Z

There were two separate problems:

I forgot to include the correct arguments for WasmKlibCheckers.makeChecker
I forgot to add the IrDiagnosticsHandler to the Wasm diagnostics test, causing the diagnostics to be never be collected from the diagnostics reporter

Thanks to @vsukharev and @alex28sh for investigating and debugging!

Re 1: I will remove the default arguments for makeChecker in another commit, as I don't see a good reason to keep them, as the function only has one use now anyway; so hopefully this will prevent someone forgettting them again in the future 🙃

KotlinBuild · 2026-04-27T14:16:24Z

Quality gate finished successfully.

jmrtsh · 2026-04-28T10:08:34Z

/dry-run

KotlinBuild · 2026-04-28T10:11:08Z

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/936377462 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5875/safe-merge
Commit: ab2b80e

broadwaylamb

/final

KotlinBuild · 2026-04-28T11:37:54Z

Quality gate finished successfully.

vsukharev · 2026-04-28T17:01:35Z

/final

jmrtsh · 2026-04-28T18:14:36Z

Rebasing manually

…4671) FirWasmJsKlibAbiDumpBeforeInliningSavingHandler now uses WebKlibSerializationPipelinePhase to deduplicate logic between them.

Don't run these checkers there, since they are already run in WebFir2IrPipelinePhase.

They were unused anyway and suggested that there were situations where empty versions of these arguments can be used, which no longer seems to be the case.

The argument is now always an `emptyList()`, no checkers are run anymore, so remove the option completely.

jmrtsh · 2026-04-28T18:16:12Z

/safe-merge

KotlinBuild · 2026-04-28T18:17:51Z

Quality gate is triggered at https://buildserver.labs.intellij.net/build/936758459 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5875/safe-merge
Commit: 1bfe328

KotlinBuild · 2026-04-28T19:41:27Z

Quality gate finished successfully.

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

jmrtsh force-pushed the jmrt/KT-74671 branch from 9d17fc9 to 39ce754 Compare April 20, 2026 11:54

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

alex28sh reviewed Apr 28, 2026

View reviewed changes

Comment thread compiler/ir/serialization.js/src/org/jetbrains/kotlin/ir/backend/js/klib.kt Outdated

broadwaylamb approved these changes Apr 28, 2026

View reviewed changes

jmrtsh requested a review from alex28sh April 28, 2026 11:38

alex28sh approved these changes Apr 28, 2026

View reviewed changes

vsukharev approved these changes Apr 28, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

jmrtsh added 5 commits April 28, 2026 20:15

[Wasm] Use phased CLI infra in first stage tests (^KT-74671)

3484487

[Wasm] Refactor FirWasmJsKlibAbiDumpBeforeInliningSavingHandler (KT-7…

301b843

…4671) FirWasmJsKlibAbiDumpBeforeInliningSavingHandler now uses WebKlibSerializationPipelinePhase to deduplicate logic between them.

[Wasm, JS] Remove klib checkers from serializeModuleIntoKlib

357ea1c

Don't run these checkers there, since they are already run in WebFir2IrPipelinePhase.

[Wasm][NFC] Remove misleading default arguments from WasmKlibCheckers

07c5df6

They were unused anyway and suggested that there were situations where empty versions of these arguments can be used, which no longer seems to be the case.

[Wasm][NFC] serializeModuleIntoKlib: remove unused platformKlibCheckers

68fdff3

The argument is now always an `emptyList()`, no checkers are run anymore, so remove the option completely.

jmrtsh force-pushed the jmrt/KT-74671 branch from 7cc6d03 to 68fdff3 Compare April 28, 2026 18:15

KotlinBuild merged commit e959bb1 into master Apr 28, 2026
1 check passed

KotlinBuild deleted the jmrt/KT-74671 branch April 28, 2026 19:41

Conversation

jmrtsh commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kotlin-safe-merge Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Owners

Uh oh!

jmrtsh commented Apr 16, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

jmrtsh commented Apr 16, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

jmrtsh commented Apr 17, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

KotlinBuild commented Apr 17, 2026

Uh oh!

jmrtsh commented Apr 20, 2026

Uh oh!

This comment was marked as outdated.

jmrtsh commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

jmrtsh commented Apr 20, 2026

Uh oh!

This comment was marked as outdated.

KotlinBuild commented Apr 20, 2026

Uh oh!

KotlinBuild commented Apr 20, 2026

Uh oh!

KotlinBuild commented Apr 20, 2026

Uh oh!

jmrtsh commented Apr 20, 2026

Uh oh!

KotlinBuild commented Apr 20, 2026

Uh oh!

jmrtsh commented Apr 20, 2026

Uh oh!

KotlinBuild commented Apr 20, 2026

Uh oh!

KotlinBuild commented Apr 20, 2026

Uh oh!

KotlinBuild commented Apr 20, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

jmrtsh commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KotlinBuild commented Apr 27, 2026

Uh oh!

Uh oh!

jmrtsh commented Apr 28, 2026

Uh oh!

KotlinBuild commented Apr 28, 2026

Uh oh!

broadwaylamb left a comment

Choose a reason for hiding this comment

Uh oh!

KotlinBuild commented Apr 28, 2026

Uh oh!

vsukharev commented Apr 28, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

jmrtsh commented Apr 28, 2026

Uh oh!

jmrtsh commented Apr 28, 2026

jmrtsh commented Apr 16, 2026 •

edited

Loading

kotlin-safe-merge Bot commented Apr 16, 2026 •

edited

Loading

jmrtsh commented Apr 20, 2026 •

edited

Loading

jmrtsh commented Apr 27, 2026 •

edited

Loading