Skip to content

[FIR2IR] Implicit cast fixes#5868

Merged
KotlinBuild merged 5 commits intomasterfrom
krakhman/dynamic_cast
Apr 21, 2026
Merged

[FIR2IR] Implicit cast fixes#5868
KotlinBuild merged 5 commits intomasterfrom
krakhman/dynamic_cast

Conversation

@cypressious
Copy link
Copy Markdown
Contributor

@cypressious cypressious commented Apr 15, 2026

No description provided.

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 15, 2026 •
edited
Loading

Code Owners

Rule Owners Approval
/​compiler/​fir/​ kotlin-frontend ✅
@demiurg906
/​compiler/​testData/​ir/​irText/​ kotlin-compiler ✅
@demiurg906, @broadwaylamb
/​js/​js.​translator/​testData/​ kotlin-js, kotlin-wasm ✅
@broadwaylamb

@cypressious cypressious requested a review from demiurg906 April 15, 2026 08:00
demiurg906
demiurg906 previously approved these changes Apr 15, 2026
View reviewed changes
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 15, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 15, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/926915958 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5868/safe-merge
Commit: 2e8172c

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 15, 2026

Triggered a retry attempt №1 out of 1.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 15, 2026

Quality gate failed. See https://buildserver.labs.intellij.net/build/926915958 to get full insight.

@kotlin-safe-merge kotlin-safe-merge Bot dismissed demiurg906’s stale review April 16, 2026 08:19

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from demiurg906 April 16, 2026 08:19
demiurg906
demiurg906 previously approved these changes Apr 16, 2026
View reviewed changes
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 16, 2026

/safe-merge

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 16, 2026

Command rejected: Commit 'fixup!' is currently not supported by GitHub - please try /fixup command or /safe-squash-merge

@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 16, 2026

/safe-merge --fixup

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 16, 2026

Autosquash aborted: Conflict detected in file(s): compiler/fir/fir2ir/src/org/jetbrains/kotlin/fir/backend/generators/CallAndReferenceGenerator.kt. Commit '[FIR2IR] Rename parameters of prepareExpressionForGivenExpectedType' and fixup 'fixup! [FIR2IR] Add missing null check in generic vararg call with flexible argument' both modify these files. Please rebase manually.

@cypressious cypressious force-pushed the krakhman/dynamic_cast branch from d44e590 to 0218625 Compare April 16, 2026 12:06
@kotlin-safe-merge kotlin-safe-merge Bot dismissed demiurg906’s stale review April 16, 2026 12:06

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from demiurg906 April 16, 2026 12:06
demiurg906
demiurg906 previously approved these changes Apr 16, 2026
View reviewed changes
@cypressious cypressious force-pushed the krakhman/dynamic_cast branch from 0218625 to 8bd4c24 Compare April 16, 2026 12:18
@kotlin-safe-merge kotlin-safe-merge Bot dismissed demiurg906’s stale review April 16, 2026 12:18

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from demiurg906 April 16, 2026 12:18
demiurg906
demiurg906 previously approved these changes Apr 16, 2026
View reviewed changes
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 16, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 16, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/927801849 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5868/safe-merge
Commit: 2bc21ed

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 16, 2026

Triggered a retry attempt №1 out of 1.

@cypressious cypressious force-pushed the krakhman/dynamic_cast branch from 8bd4c24 to defaefa Compare April 16, 2026 13:26
@kotlin-safe-merge kotlin-safe-merge Bot dismissed demiurg906’s stale review April 16, 2026 13:26

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from demiurg906 April 16, 2026 13:26
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 16, 2026

Rebased to resolve merge conflict

demiurg906
demiurg906 previously approved these changes Apr 16, 2026
View reviewed changes
@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 16, 2026

Quality gate failed. See https://buildserver.labs.intellij.net/build/927801849 to get full insight.

@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 16, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 16, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/927875353 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5868/safe-merge
Commit: 5a4d5c5

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 16, 2026

Triggered a retry attempt №1 out of 1.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 16, 2026

Quality gate failed. See https://buildserver.labs.intellij.net/build/927875353 to get full insight.

@kotlin-safe-merge kotlin-safe-merge Bot dismissed demiurg906’s stale review April 20, 2026 07:57

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from demiurg906 April 20, 2026 07:57
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 20, 2026

/safe-merge --fixup

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 20, 2026

Command rejected: Missing code owners approval - verify the check 'Code Owners Approval' is green.

broadwaylamb
broadwaylamb requested changes Apr 21, 2026
View reviewed changes
Comment thread js/js.translator/testData/box/jsCode/compareTo.kt Outdated
@cypressious cypressious force-pushed the krakhman/dynamic_cast branch from 4979d73 to 21933d7 Compare April 21, 2026 13:47
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 21, 2026

/safe-merge --fixup

@kotlin-safe-merge kotlin-safe-merge Bot force-pushed the krakhman/dynamic_cast branch from 21933d7 to 21b88fa Compare April 21, 2026 17:31
@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 21, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/931782527 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5868/safe-merge
Commit: fd908ab

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 21, 2026

Quality gate finished successfully.

@KotlinBuild KotlinBuild merged commit 56dd720 into master Apr 21, 2026
1 check passed
@KotlinBuild KotlinBuild deleted the krakhman/dynamic_cast branch April 21, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demiurg906 demiurg906 demiurg906 approved these changes

@broadwaylamb broadwaylamb broadwaylamb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cypressious @KotlinBuild @demiurg906 @broadwaylamb