Skip to content

KT-85647 Normalize path lazily and add a cache to that normalization#5853

Merged
KotlinBuild merged 1 commit intoJetBrains:masterfrom
alfonsocv12:fix/librarylistregression
Apr 22, 2026
Merged

KT-85647 Normalize path lazily and add a cache to that normalization#5853
KotlinBuild merged 1 commit intoJetBrains:masterfrom
alfonsocv12:fix/librarylistregression

Conversation

@alfonsocv12
Copy link
Copy Markdown
Contributor

@alfonsocv12 alfonsocv12 commented Apr 11, 2026 •
edited
Loading

This fixes a regression in codegeneration optimizing for the worst case we found LibraryList.accepts goes from ~2 seconds to 146 ms.

details in issue

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 11, 2026 •
edited
Loading

Code Owners

RuleOwnersApproval
/​compiler/​fir/​
kotlin-frontend
✅
@KvanTTT

@alfonsocv12 alfonsocv12 force-pushed the fix/librarylistregression branch 2 times, most recently from 775c335 to 8e510f6 Compare April 11, 2026 17:18
@alfonsocv12 alfonsocv12 changed the title Normalize path lazyly and add a cache to that normalization Normalize path lazily and add a cache to that normalization Apr 11, 2026
@alfonsocv12 alfonsocv12 marked this pull request as ready for review April 11, 2026 17:19
@alfonsocv12 alfonsocv12 changed the title Normalize path lazily and add a cache to that normalization KT-85647 Normalize path lazily and add a cache to that normalization Apr 11, 2026
@mglukhikh mglukhikh requested a review from KvanTTT April 13, 2026 13:13
@alfonsocv12 alfonsocv12 force-pushed the fix/librarylistregression branch from 8e510f6 to f348a7a Compare April 14, 2026 01:27
KvanTTT
KvanTTT reviewed Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@KvanTTT KvanTTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I launched your changed on internal performance tests and it shown small some performance improvements (at least not degradation). Thanks!

Comment thread ...zation/src/org/jetbrains/kotlin/fir/deserialization/AbstractFirDeserializedSymbolProvider.kt
@alfonsocv12 alfonsocv12 force-pushed the fix/librarylistregression branch from f348a7a to fa0b7e3 Compare April 21, 2026 17:41
@KvanTTT
Copy link
Copy Markdown
Contributor

KvanTTT commented Apr 22, 2026

/dry-run

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932228816 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5853/safe-merge
Commit: 8753652

@KvanTTT
Copy link
Copy Markdown
Contributor

KvanTTT commented Apr 22, 2026

Also, I recommend using ^KT-85647 Fixed syntax in commit messages. It allows closing (actually changing any status) of the issue automatically during merging.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate finished successfully.

@KvanTTT
Copy link
Copy Markdown
Contributor

KvanTTT commented Apr 22, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932369946 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5853/safe-merge
Commit: 8753652

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Triggered a retry attempt №1 out of 1.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate failed. See https://buildserver.labs.intellij.net/build/932369946 to get full insight.

@KvanTTT
Copy link
Copy Markdown
Contributor

KvanTTT commented Apr 22, 2026 •
edited
Loading

@alfonsocv12 I'm retyring the safe-merge and if it fails again, could you please rebase your branch on the latest master? There is a compilation error that breaks some checks. And I'll merge it afterwards.

@KvanTTT
Copy link
Copy Markdown
Contributor

KvanTTT commented Apr 22, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932434206 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5853/safe-merge
Commit: 97a2337

@alfonsocv12 alfonsocv12 force-pushed the fix/librarylistregression branch from fa0b7e3 to a0c64ed Compare April 22, 2026 14:06
@alfonsocv12
Copy link
Copy Markdown
Contributor Author

alfonsocv12 commented Apr 22, 2026

@alfonsocv12 I'm retyring the safe-merge and if it fails again, could you please rebase your branch on the latest master? There is a compilation error that breaks some checks. And I'll merge it afterwards.

Done

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate finished successfully.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Error: Failed all 5 attempts, see nested exception for details

@alfonsocv12
Copy link
Copy Markdown
Contributor Author

alfonsocv12 commented Apr 22, 2026

Error: Failed all 5 attempts, see nested exception for details

Hello @KvanTTT theres some failures do you need me to do something else here? I can't see the exception

@alfonsocv12
[FIR] Fixes regression in LibraryList.accepts by normalize path lazil…
c4fb42c 
…y and add a cache to that normalization

^KT-85647 Fixed
@alfonsocv12 alfonsocv12 force-pushed the fix/librarylistregression branch from a0c64ed to c4fb42c Compare April 22, 2026 18:44
@alfonsocv12
Copy link
Copy Markdown
Contributor Author

alfonsocv12 commented Apr 22, 2026

Also, I recommend using ^KT-85647 Fixed syntax in commit messages. It allows closing (actually changing any status) of the issue automatically during merging.

Reword the commit message to make have this.

Also rebase with master again hopefully this fixes the problem

@KvanTTT
Copy link
Copy Markdown
Contributor

KvanTTT commented Apr 22, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932803593 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5853/safe-merge
Commit: 826ee40

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate finished successfully.

@KotlinBuild KotlinBuild merged commit 5d707a7 into JetBrains:master Apr 22, 2026
1 check passed
@KvanTTT
Copy link
Copy Markdown
Contributor

KvanTTT commented Apr 23, 2026

Hello @KvanTTT theres some failures do you need me to do something else here? I can't see the exception

It turned out nothing was needed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KvanTTT KvanTTT KvanTTT approved these changes

Assignees

@KvanTTT KvanTTT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alfonsocv12 @KvanTTT @KotlinBuild