Skip to content

[FIR] Keep all inapplicable candidates as long as no applicable one was found KT-72706#5849

Merged
KotlinBuild merged 2 commits intomasterfrom
krakhman/inapplicable_candidates
Apr 22, 2026
Merged

[FIR] Keep all inapplicable candidates as long as no applicable one was found KT-72706#5849
KotlinBuild merged 2 commits intomasterfrom
krakhman/inapplicable_candidates

Conversation

@cypressious
Copy link
Copy Markdown
Contributor

@cypressious cypressious commented Apr 10, 2026

No description provided.

@kotlin-safe-merge
Copy link
Copy Markdown

kotlin-safe-merge Bot commented Apr 10, 2026 •
edited
Loading

Code Owners

RuleOwnersApproval
/​analysis/​
kotlin-analysis-api
✅
@dimonchik0036
/​compiler/​fir/​, /​compiler/​testData/​diagnostics/​, /​compiler/​tests-​spec/​
kotlin-frontend
✅
@dzharkov

@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 10, 2026

/dry-run

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 10, 2026

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/923429469 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5849/safe-merge
Commit: 19fe074

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 10, 2026

Triggered a retry attempt №1 out of 1.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 10, 2026

Quality gate failed. See https://buildserver.labs.intellij.net/build/923429469 to get full insight.

@cypressious cypressious force-pushed the krakhman/inapplicable_candidates branch from 649d3ea to 8b2014f Compare April 13, 2026 11:30
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 13, 2026

/dry-run

@JetBrains JetBrains deleted a comment from kotlin-safe-merge Bot Apr 13, 2026
@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 13, 2026

THIS IS A DRY RUN

Quality gate is triggered at https://buildserver.labs.intellij.net/build/924707930 — use this link to get full insight.

Corresponding Merge-Request in ultimate is found.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5849/safe-merge
Commit: ba48129

ultimate
Branch: refs/coordinator/safe-merge/refs/merge/GITHUB-5849/safe-merge
Commit: f902a6a

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 13, 2026

Quality gate finished successfully.

dzharkov
dzharkov requested changes Apr 14, 2026
View reviewed changes
Comment thread compiler/testData/diagnostics/tests/dynamicTypes/withInvisibleSynthesized.kt
@cypressious cypressious requested a review from dzharkov April 20, 2026 10:55
dzharkov
dzharkov previously approved these changes Apr 20, 2026
View reviewed changes
@cypressious cypressious force-pushed the krakhman/inapplicable_candidates branch from 8b2014f to 7761e8a Compare April 20, 2026 12:14
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 20, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 20, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/930465607 — use this link to get full insight.

Corresponding Merge-Request in ultimate is found.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5849/safe-merge
Commit: 7761e8a

ultimate
Branch: refs/coordinator/safe-merge/refs/merge/GITHUB-5849/safe-merge
Commit: da364de

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 20, 2026

Triggered a retry attempt №1 out of 1.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 20, 2026

Quality gate failed. See https://buildserver.labs.intellij.net/build/930465607 to get full insight.

@cypressious cypressious force-pushed the krakhman/inapplicable_candidates branch from 7761e8a to 663d6e5 Compare April 21, 2026 07:14
@kotlin-safe-merge kotlin-safe-merge Bot dismissed dzharkov’s stale review April 21, 2026 07:14

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from dzharkov April 21, 2026 07:14
@cypressious cypressious force-pushed the krakhman/inapplicable_candidates branch from 663d6e5 to 8391da0 Compare April 22, 2026 06:34
dzharkov
dzharkov previously approved these changes Apr 22, 2026
View reviewed changes
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 22, 2026

/safe-merge --fixup

@kotlin-safe-merge kotlin-safe-merge Bot force-pushed the krakhman/inapplicable_candidates branch from 8391da0 to 54b4fce Compare April 22, 2026 09:39
@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932223424 — use this link to get full insight.

Corresponding Merge-Request in ultimate is found.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5849/safe-merge
Commit: 186bfd2

ultimate
Branch: refs/coordinator/safe-merge/refs/merge/GITHUB-5849/safe-merge
Commit: 5d5dd82

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Triggered a retry attempt №1 out of 1.

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate failed. See https://buildserver.labs.intellij.net/build/932223424 to get full insight.

@cypressious cypressious force-pushed the krakhman/inapplicable_candidates branch from 54b4fce to 39c8f1c Compare April 22, 2026 11:35
@kotlin-safe-merge kotlin-safe-merge Bot dismissed dzharkov’s stale review April 22, 2026 11:35

New changes affect files owned by this reviewer. Re-review required.

@kotlin-safe-merge kotlin-safe-merge Bot requested a review from dzharkov April 22, 2026 11:35
@cypressious
Copy link
Copy Markdown
Contributor Author

cypressious commented Apr 22, 2026

/safe-merge

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate is triggered at https://buildserver.labs.intellij.net/build/932675020 — use this link to get full insight.

Corresponding Merge-Request in ultimate is found.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5849/safe-merge
Commit: 938e2ee

ultimate
Branch: refs/coordinator/safe-merge/refs/merge/GITHUB-5849/safe-merge
Commit: cefff88

@KotlinBuild
Copy link
Copy Markdown

KotlinBuild commented Apr 22, 2026

Quality gate finished successfully.

@KotlinBuild KotlinBuild merged commit b411e6c into master Apr 22, 2026
1 check passed
@KotlinBuild KotlinBuild deleted the krakhman/inapplicable_candidates branch April 22, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzharkov dzharkov dzharkov approved these changes

@dimonchik0036 dimonchik0036 dimonchik0036 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cypressious @KotlinBuild @dzharkov @dimonchik0036