Repository navigation
Fix access violation when closing server dialog - #28
Merged
Merged
Conversation
The GUI thread was deleting KAILLERAC.connection while the emulator thread was still using it inside kaillera_step(). The KAILLERA_CORE_INITIALIZED guard was set to false after cleanup instead of before, so the emulator thread could race past the check. - Set KAILLERA_CORE_INITIALIZED = false before disconnect/cleanup - Null the connection pointer before deleting the object - Add kaillera_step_active volatile flag so cleanup spin-waits for any in-flight kaillera_step() to finish (check_sockets blocks up to 200ms) - Add null checks inside kaillera_step() loop body Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GUI thread was deleting KAILLERAC.connection while the emulator thread was still using it inside kaillera_step(). The KAILLERA_CORE_INITIALIZED guard was set to false after cleanup instead of before, so the emulator thread could race past the check.