Skip to content

Adding support for RedisCluster (phpredis extension) - #1

Open
JacobBrownAustin wants to merge 31 commits into
masterfrom
ClusterClient
Open

Adding support for RedisCluster (phpredis extension)#1
JacobBrownAustin wants to merge 31 commits into
masterfrom
ClusterClient

Conversation

@JacobBrownAustin

Copy link
Copy Markdown
Owner

No description provided.

@kandy kandy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

Comment thread ClusterClient.php Outdated
Comment thread ClusterClient.php Outdated
Comment thread ClusterClient.php Outdated
$this->timeout,
$this->readTimeout,
$this->persistentBool, // Note: This can't be $this->persistent, because it is string
['user' => $this->authUsername, 'pass' => $this->authUsername],

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'pass' => $this->authUsername

🤦

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in 1f46776

JacobBrownAustin and others added 25 commits September 16, 2024 14:17
* Credis_Cluster class now replaced with new class that uses
  RedisCluster.
* Updated tests
  * Lots of tests skipped because of broken/missing features or
    incompatible behaviour because of Redis clusters or RedisCluster
* Adding PHP 8.3 test container to run the phpunit tests
flushDb, flushAll, & ping get called on all masters now in
Credis_Cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants