Skip to content

fix visual snap of side pane on startup #15553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Siedlerchr merged 10 commits into from
Apr 19, 2026
+6 −1
Merged

fix visual snap of side pane on startup #15553

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06cb696
fix visual snap of side pane on startup
pgrigolli Apr 10, 2026
7ed4ea5
Fix side pane snap by applying divider position when stage is showing
pgrigolli Apr 10, 2026
0c02a92
Fix side pane snap by hiding the side pane until the loading and coor…
pgrigolli Apr 15, 2026
663738a
Changelog
pgrigolli Apr 15, 2026
bf22cc6
Merge branch 'main' into fix-for-issue-15394
pgrigolli Apr 15, 2026
ace702f
Changelog line removal
pgrigolli Apr 15, 2026
f832809
changelog.md description more concise
pgrigolli Apr 15, 2026
e9e5b5c
Removing dead code
pgrigolli Apr 15, 2026
5d55b54
Merge branch 'main' into fix-for-issue-15394
subhramit Apr 16, 2026
b75e056
Merge branch 'main' into fix-for-issue-15394
subhramit Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Added

- We removed a little snap that used to happen with the side panel when one opened JabRef after changing the side panel's default position [#15394](https://github.com/JabRef/jabref/issues/15394)
Comment thread
pgrigolli marked this conversation as resolved.
Outdated
- We added a related work text extractor, which finds and inserts the related work text into bib entries from references in the texts. [#9840](https://github.com/JabRef/jabref/issues/9840)
- We added a hover button on group rows to quickly add a new group or subgroup. [#12289](https://github.com/JabRef/jabref/issues/12289)
- We added a shorthand for protecting terms in the fields: user can now select a text and type a opening curling brace to quickly wrap the selection in braces. [#15442](https://github.com/JabRef/jabref/pull/15442)
Expand Down
12 changes: 11 additions & 1 deletion jabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,12 @@ private void updateSidePane() {
horizontalSplit.getItems().remove(sidePane);
} else {
if (!horizontalSplit.getItems().contains(sidePane)) {
horizontalSplit.setVisible(false);
horizontalSplit.getItems().addFirst(sidePane);
updateHorizontalDividerPosition();
Platform.runLater(() -> {
updateHorizontalDividerPosition();
horizontalSplit.setVisible(true);
});
}
}
}
Expand Down Expand Up @@ -407,6 +411,12 @@ private void initKeyBindings() {
private void initBindings() {
BindingsHelper.bindContentFiltered(tabbedPane.getTabs(), stateManager.getOpenDatabases(), LibraryTab.class::isInstance);

mainStage.showingProperty().addListener((obs, wasShowing, isShowing) -> {
if (isShowing) {
updateHorizontalDividerPosition();
}
});
Copy link
Copy Markdown
Contributor

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Leaked divider subscriptions 🐞 Bug ☼ Reliability

initBindings() adds a mainStage.showingProperty listener that calls
updateHorizontalDividerPosition(), but JabRefGUI.onShowing() already calls it; because
updateHorizontalDividerPosition() overwrites horizontalDividerSubscription without unsubscribing
the previous subscription, repeated window show cycles will leak listeners and duplicate preference
updates.
Agent Prompt 
### Issue description
`updateHorizontalDividerPosition()` installs an EasyBind listener each time it runs, but it does not unsubscribe any prior listener. This PR adds an additional call site (`mainStage.showingProperty` listener), while `JabRefGUI.onShowing()` already calls the method, so subscriptions can stack up across show/hide cycles.

### Issue Context
- `JabRefGUI.onShowing()` already calls `mainFrame.updateHorizontalDividerPosition()`.
- `updateHorizontalDividerPosition()` assigns `horizontalDividerSubscription = ...listenToValues(...)` without cleanup.

### Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java[311-320]
- jabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java[411-418]
- jabgui/src/main/java/org/jabref/gui/JabRefGUI.java[357-361]

### Suggested fix approach
- Prefer a single invocation path (remove the newly-added `showingProperty` listener, since `JabRefGUI.onShowing()` already handles it), **or**
- Make `updateHorizontalDividerPosition()` idempotent by unsubscribing an existing `horizontalDividerSubscription` before creating a new one (and consider doing the same for vertical for consistency).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Copy Markdown
Member

@calixtus calixtus Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgrigolli needs to be addressed

Copy link
Copy Markdown
Contributor Author

@pgrigolli pgrigolli Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, turns out it was just dead code that I forgot to remove from one try to another. Removed on the last commit!


// the binding for stateManager.activeDatabaseProperty() is at org.jabref.gui.LibraryTab.onDatabaseLoadingSucceed

// Subscribe to the search
Expand Down
Loading