Skip to content

Added FISM optimisations, untested due to Iris code not building#3168

Open
maDU59 wants to merge 1 commit into
IrisShaders:26.1from
maDU59:26.1
Open

Added FISM optimisations, untested due to Iris code not building#3168
maDU59 wants to merge 1 commit into
IrisShaders:26.1from
maDU59:26.1

Conversation

@maDU59

@maDU59 maDU59 commented Jun 21, 2026

Copy link
Copy Markdown

All needed informations are available here:

https://modrinth.com/mod/fism

maDU59/FasterIrisShadowMapper#4

@SpacEagle17

SpacEagle17 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Some packs might want these things rendered in the shadow pass though.
If anything, a new shaders.properties argument has to be added to disable this functionality, so packs can get the previous behaviour if needed

And regarding not being able to build iris, what are the issues? Usually, I just uncomment Neoforge from the settings.gradle task and ensure the right sodium version is the dependency. That does it usually

@maDU59

maDU59 commented Jun 21, 2026

Copy link
Copy Markdown
Author

I thought the same as you, that's why I originally made it an optional mod, but I talked about it with IMS before hand and here's what he said:

I think it could be worth making a PR, looking at it now

as long as it's just opaque objects, I don't think it needs a toggle

As for the building process, I just thought the repo was not in the build-ready process, I didn't know it was an easy fix. It should work anyway given how small the code is, at worst there's a missing import somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants