You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allows .authCommitteeHot() and .resignCommitteeCold() to build CC certificates whose cold credential is a native (multisig) script. These are authorized by vkey witnesses, not a redeemer, so requiring one made ledger-valid certificates unbuildable. A redeemer is now required only for Plutus-script cold credentials, one supplied for a native script is pruned.
On the tests: they all go through .attachScript(), but makeIsNativeScript also classifies the native script when it comes in via a reference input. Might be worth a case for that path too, unless you're covering it somewhere I missed.
One to think about:validateCertRedeemers runs for the DRep and CC certs. Did you consider whether script-controlled stake certs (deregistration/delegation) need the same treatment, or are those covered elsewhere? Not saying they should be in this PR, just flagging it in case it's worth a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
.authCommitteeHot()and.resignCommitteeCold()to build CC certificates whose cold credential is a native (multisig) script. These are authorized by vkey witnesses, not a redeemer, so requiring one made ledger-valid certificates unbuildable. A redeemer is now required only for Plutus-script cold credentials, one supplied for a native script is pruned.Closes #448
Blocked on #447