Skip to content

cardano-testnet: re-enable RPC ReadGenesis initialFunds assertion - #6657

Draft
carbolymer wants to merge 2 commits into
masterfrom
mgalazyn/test/rpc-readgenesis-initialfunds
Draft

cardano-testnet: re-enable RPC ReadGenesis initialFunds assertion#6657
carbolymer wants to merge 2 commits into
masterfrom
mgalazyn/test/rpc-readgenesis-initialfunds

Conversation

@carbolymer

@carbolymer carbolymer commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Stacked on #6655.

Re-enables the initialFunds assertion in the ReadGenesis RPC test.

The assertion was temporarily disabled because cardano-rpc read only the legacy sgInitialFunds field, while cardano-cli create-testnet-data provisions wallets via sgExtraConfig.secInitialFunds, so the RPC response reported no funds for testnet-data networks.

Depends on the cardano-rpc fix on IntersectMBO/cardano-api#1305, consumed here via a temporary source-repository-package stanza in cabal.project.

DO NOT MERGE until cardano-rpc is released to CHaP with the fix and the SRP stanza is dropped.
This PR exists to prove CI goes green with the fix in place.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
    • cardano-node-chairman, cardano-submit-api and cardano-testnet instead need a
      changelog fragment in <package>/.changes/, because their CHANGELOG.md is generated
      from fragments at release time. Copy _TEMPLATE.yml from that directory, or run
      nix run github:input-output-hk/cardano-dev#herald -- new
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer
carbolymer requested a review from a team as a code owner August 20, 2026 14:21
@carbolymer
carbolymer changed the base branch from master to mgalazyn/test/rpc-readgenesis-followtip-fetchblock August 20, 2026 14:21
@carbolymer carbolymer self-assigned this Aug 20, 2026
@carbolymer
carbolymer marked this pull request as draft August 20, 2026 14:22
@carbolymer carbolymer changed the title Mgalazyn/test/rpc readgenesis initialfunds cardano-testnet: re-enable RPC ReadGenesis initialFunds assertion Aug 20, 2026
This reverts the temporary relaxation from 764a27f.
cardano-rpc now resolves initial funds from the genesis sgExtraConfig, so the ReadGenesis RPC response carries the wallets that cardano-testnet's create-testnet-data provisions, and the strict assertion holds again.
Points cardano-rpc at the fix on the IntersectMBO/cardano-api branch
mgalazyn/fix/rpc-initial-funds-extraconfig.

Must be dropped once cardano-rpc is released to CHaP with the fix.
@carbolymer
carbolymer force-pushed the mgalazyn/test/rpc-readgenesis-initialfunds branch from 9343bd0 to 521778a Compare August 20, 2026 14:25
Base automatically changed from mgalazyn/test/rpc-readgenesis-followtip-fetchblock to master August 20, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant