fix: tolerate option groups in "Missing: " errors - #3699
Merged
Merged
Conversation
cardano-cli renders empty option-group markers between the
"Missing: " prefix and the missing option, e.g.
Missing: ( ) ( ) --fee LOVELACE
ddf9ff4 replaced the `.*` in these patterns with ` +`, which only
matches spaces, so `test_missing_fee` and
`test_build_missing_change_address` stopped matching and failed.
Use `[^\n]*` instead: it keeps the variable-padding tolerance, accepts
the group markers, and stays anchored to the single "Missing: " line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cardano-cli renders empty option-group markers between the "Missing: " prefix and the missing option, e.g.
ddf9ff4 replaced the
.*in these patterns with+, which only matches spaces, sotest_missing_feeandtest_build_missing_change_addressstopped matching and failed.Use
[^\n]*instead: it keeps the variable-padding tolerance, acceptsthe group markers, and stays anchored to the single "Missing: " line.