Skip to content

Add key mnemonic test - #3129

Merged
mkoura merged 2 commits into
masterfrom
add_key_mnemonic_test
Sep 10, 2025
Merged

mkoura merged 2 commits into
masterfrom
add_key_mnemonic_test

Conversation

@mkoura

@mkoura mkoura commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Update cardano-clusterlib dependency to version 0.9.4 in pyproject.toml and
poetry.lock for making key mnemonic methods available.
@mkoura
mkoura requested a review from saratomaz as a code owner September 10, 2025 16:45
@mkoura
mkoura requested a review from Copilot September 10, 2025 16:53

This comment was marked as outdated.

Add parameterized tests for generating and deriving keys from mnemonic
sentences. Covers multiple mnemonic sizes, output formats, key types,
and derivation paths. Ensures generated keys exist and match expected
properties.
@mkoura
mkoura force-pushed the add_key_mnemonic_test branch from 2fa81fc to a12f927 Compare September 10, 2025 16:59
@mkoura
mkoura requested a review from Copilot September 10, 2025 17:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test for key mnemonic functionality by creating a comprehensive test suite for generating and deriving keys from mnemonic sentences.

  • Adds a new test module test_mnemonic.py with parametrized tests for mnemonic generation and key derivation
  • Updates the cardano-clusterlib dependency from version ^0.9.3 to ^0.9.4

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Updates cardano-clusterlib dependency to version 0.9.4
cardano_node_tests/tests/test_mnemonic.py Adds comprehensive test for mnemonic generation and key derivation with multiple parameter combinations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cardano_node_tests/tests/test_mnemonic.py
Comment thread cardano_node_tests/tests/test_mnemonic.py
@mkoura
mkoura merged commit f0f4bb9 into master Sep 10, 2025
4 checks passed
@mkoura
mkoura deleted the add_key_mnemonic_test branch September 10, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants