Add MaxMind GeoLite Country crawler - #242
Merged
Merged
Conversation
Adds support for the free MaxMind IP geolocation database. This data is already integrated via the ihr.rov crawler, but our modeling has changed and geolocation is not really the purpose of the ROV crawler. Separating this into its own crawler makes things more logical, so the country information is not imported by ihr.rov anymore.
romain-fontugne
approved these changes
Jul 14, 2026
romain-fontugne
left a comment
Member
There was a problem hiding this comment.
Looks good to me, just a couple typos in the doc.
Co-authored-by: Romain Fontugne <romain-fontugne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the free MaxMind IP geolocation database. This data is already integrated via the ihr.rov crawler, but our modeling has changed and geolocation is not really the purpose of the ROV crawler.
Separating this into its own crawler makes things more logical, so the country information is not imported by ihr.rov anymore.
Description
The imported data has pretty much the same format as the existing IPinfo crawler. Map GeoPrefix to Country nodes. Relationship properties are a bit different, but only included for completeness anyways.
Also removes the Country part from ihr.rov.
Motivation and Context
Currently we already include MaxMind data (although not all of it) via the ihr.rov crawler. However, this is a bit unclean and also uses the old model where we mapped BGPPrefix nodes to Country nodes. Separating these parts makes everything cleaner. We can also use it to compare IPinfo and MaxMind discrepancies.
How Has This Been Tested?
Tested the new crawler and also checked that ihr.rov still works.
Types of changes
Checklist: