[Feature] Log efficient_attn_ratio and img_efficient_attn_ratio to exp_tracker#1666
Open
claude[bot] wants to merge 1 commit intomainfrom
Open
[Feature] Log efficient_attn_ratio and img_efficient_attn_ratio to exp_tracker#1666claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
…p_tracker Add efficient_attn_ratio and img_efficient_attn_ratio to the log_scalars dict in _log_step so they are recorded by the experiment tracker under the runtime_info/ prefix. Also update FakeEngine mock in tests to include the missing step_consumed_img_tokens and img_efficient_attn_ratio fields. Closes #1665
Collaborator
|
@claude directly merge it after unit test passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
efficient_attn_ratioandimg_efficient_attn_ratioto the experiment tracker scalars under theruntime_info/prefix inTrainer._log_step()FakeEnginemock in tests to include the missingstep_consumed_img_tokensandimg_efficient_attn_ratiofieldsChanges
xtuner/v1/train/trainer.py: Added two new entries tolog_scalarsdicttests/train/test_trainer.py: UpdatedFakeEngine.train_step()return value to match fullTrainStepInfoschemaTest plan
Closes #1665